You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2023/01/05 00:13:09 UTC
[GitHub] [superset] john-bodley opened a new pull request, #22594: chore(connector): Deprecate connectors.base
john-bodley opened a new pull request, #22594:
URL: https://github.com/apache/superset/pull/22594
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
I was running into CI issues in https://github.com/apache/superset/pull/22413 which I _suspect_ maybe related to the fact that we base datasources/columns/metrics which might not adhere to the SQLAlchemy relationship model.
Somewhat of a Yak Shaving experience, this PR simply deprecates the abstract classes which are no longer needed given that we no longer support the native Druid connector. Note this refactor effort is far from complete—there endless spaghetti code which uses a datasource type mapping—but _hopefully_ it's a step (albeit small) in the right direction.
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley closed pull request #22594: chore(connector): Deprecate connectors.base
Posted by GitBox <gi...@apache.org>.
john-bodley closed pull request #22594: chore(connector): Deprecate connectors.base
URL: https://github.com/apache/superset/pull/22594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on a diff in pull request #22594: chore(connector): Deprecate connectors.base
Posted by GitBox <gi...@apache.org>.
john-bodley commented on code in PR #22594:
URL: https://github.com/apache/superset/pull/22594#discussion_r1061986946
##########
superset/charts/dao.py:
##########
@@ -27,9 +27,6 @@
from superset.models.slice import Slice
from superset.utils.core import get_user_id
-if TYPE_CHECKING:
- from superset.connectors.base.models import BaseDatasource
Review Comment:
This was never used. I'm surprised Pylint didn't recognize it, but maybe it's not well versed with the `TYPE_CHECKING` construct and thus it felt it was used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org