[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #74: make sure that no pekko version specified to build against is same as "default"

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #74:
URL: https://github.com/apache/incubator-pekko-http/pull/74#discussion_r1112873237


##########
project/PekkoDependency.scala:
##########
@@ -45,9 +45,8 @@ object PekkoDependency {
             // (typically for the docs that require 2.6)
             if (defaultVersion.startsWith("1.0")) Artifact(determineLatestSnapshot("0.0.0"), true)
             else Artifact(defaultVersion)
-          case Some("default") => Artifact(defaultVersion)
-          case Some(other)     => Artifact(other, true)
-          case None            =>
+          case Some(other)            => Artifact(other, true)
+          case Some("default") | None =>

Review Comment:
   Can we add a `NOTE` here stating that this should be reverted once a pekko release is made?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org