You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "song bruce zhang (Code Review)" <ge...@cloudera.org> on 2016/08/06 07:51:56 UTC
[kudu-CR] KUDU-1552: schema corruption cause kudu crash
song bruce zhang has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3856
Change subject: KUDU-1552: schema corruption cause kudu crash
......................................................................
KUDU-1552: schema corruption cause kudu crash
In some corner case, schema does not have column ids,
kudu-tserver will crash when starting up, after
previous node crash.
Change-Id: Ia66a39c0f1273c310e1fe19f52672e23f9771c41
---
M src/kudu/tablet/tablet.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/3856/1
--
To view, visit http://gerrit.cloudera.org:8080/3856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia66a39c0f1273c310e1fe19f52672e23f9771c41
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang <zs...@gmail.com>
[kudu-CR] KUDU-1552: schema corruption cause kudu crash
Posted by "song bruce zhang (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3856
to look at the new patch set (#4).
Change subject: KUDU-1552: schema corruption cause kudu crash
......................................................................
KUDU-1552: schema corruption cause kudu crash
In some corner case, schema does not have column ids,
kudu-tserver will crash when starting up, after
previous node crash.
I placed a branch before check/dcheck and return
Status::corruption if schema is corrupted.
Change-Id: Ia66a39c0f1273c310e1fe19f52672e23f9771c41
---
M src/kudu/tablet/tablet.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/3856/4
--
To view, visit http://gerrit.cloudera.org:8080/3856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia66a39c0f1273c310e1fe19f52672e23f9771c41
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang <zs...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1552: schema corruption cause kudu crash
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: KUDU-1552: schema corruption cause kudu crash
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/2731/
--
To view, visit http://gerrit.cloudera.org:8080/3856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia66a39c0f1273c310e1fe19f52672e23f9771c41
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang <zs...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] KUDU-1552: schema corruption cause kudu crash
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1552: schema corruption cause kudu crash
......................................................................
Patch Set 4:
Do we have any idea why this is happening, yet? I agree that crashing is not good behavior, but I also would like to understand the root cause.
--
To view, visit http://gerrit.cloudera.org:8080/3856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia66a39c0f1273c310e1fe19f52672e23f9771c41
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang <zs...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1552: schema corruption cause kudu crash
Posted by "song bruce zhang (Code Review)" <ge...@cloudera.org>.
song bruce zhang has uploaded a new patch set (#2).
Change subject: KUDU-1552: schema corruption cause kudu crash
......................................................................
KUDU-1552: schema corruption cause kudu crash
In some corner case, schema does not have column ids,
kudu-tserver will crash when starting up, after
previous node crash.
I placed a branch before check/dcheck and return
Status::corruption if schema is corrupted.
Change-Id: Ia66a39c0f1273c310e1fe19f52672e23f9771c41
---
M src/kudu/tablet/tablet.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/3856/2
--
To view, visit http://gerrit.cloudera.org:8080/3856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia66a39c0f1273c310e1fe19f52672e23f9771c41
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang <zs...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1552: schema corruption cause kudu crash
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: KUDU-1552: schema corruption cause kudu crash
......................................................................
Patch Set 3:
Build Started http://104.196.14.100/job/kudu-gerrit/2732/
--
To view, visit http://gerrit.cloudera.org:8080/3856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia66a39c0f1273c310e1fe19f52672e23f9771c41
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang <zs...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] KUDU-1552: schema corruption cause kudu crash
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: KUDU-1552: schema corruption cause kudu crash
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2730/
--
To view, visit http://gerrit.cloudera.org:8080/3856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia66a39c0f1273c310e1fe19f52672e23f9771c41
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang <zs...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] KUDU-1552: schema corruption cause kudu crash
Posted by "song bruce zhang (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3856
to look at the new patch set (#3).
Change subject: KUDU-1552: schema corruption cause kudu crash
......................................................................
KUDU-1552: schema corruption cause kudu crash
In some corner case, schema does not have column ids,
kudu-tserver will crash when starting up, after
previous node crash.
I placed a branch before check/dcheck and return
Status::corruption if schema is corrupted.
Change-Id: Ia66a39c0f1273c310e1fe19f52672e23f9771c41
---
M src/kudu/tablet/tablet.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/3856/3
--
To view, visit http://gerrit.cloudera.org:8080/3856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia66a39c0f1273c310e1fe19f52672e23f9771c41
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang <zs...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1552: schema corruption cause kudu crash
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has abandoned this change.
Change subject: KUDU-1552: schema corruption cause kudu crash
......................................................................
Abandoned
I think the commit message here wasn't right - it should be KUDU-1551, which is resolved by http://gerrit.cloudera.org:8080/5276
--
To view, visit http://gerrit.cloudera.org:8080/3856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia66a39c0f1273c310e1fe19f52672e23f9771c41
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang <zs...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1552: schema corruption cause kudu crash
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: KUDU-1552: schema corruption cause kudu crash
......................................................................
Patch Set 4:
Build Started http://104.196.14.100/job/kudu-gerrit/2733/
--
To view, visit http://gerrit.cloudera.org:8080/3856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia66a39c0f1273c310e1fe19f52672e23f9771c41
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang <zs...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No