[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

[mgummelt <gi...@git.apache.org>]

Github user mgummelt commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11157#discussion_r62135836
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala ---
    @@ -72,13 +71,13 @@ private[spark] class CoarseMesosSchedulerBackend(
       private val shuffleServiceEnabled = conf.getBoolean("spark.shuffle.service.enabled", false)
     
       // Cores we have acquired with each Mesos task ID
    -  val coresByTaskId = new HashMap[String, Int]
    +  val coresByTaskId = new mutable.HashMap[String, Int]
    --- End diff --
    
    Why make these mutable?  AFAICT, they don't need to be.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org