You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/02/03 08:32:53 UTC

[GitHub] [zookeeper] ztzg commented on a change in pull request #1241: ZOOKEEPER-3711: Dispose SaslServer instances after use

ztzg commented on a change in pull request #1241: ZOOKEEPER-3711: Dispose SaslServer instances after use
URL: https://github.com/apache/zookeeper/pull/1241#discussion_r373972419
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperSaslServer.java
 ##########
 @@ -57,8 +57,10 @@ public String getAuthorizationID() {
         return saslServer.getAuthorizationID();
     }
 
+    /**
+     * Disposes the SaslServer instance.  This method is idempotent.
+     */
+    public void dispose() throws SaslException {
+        saslServer.dispose();
 
 Review comment:
   Good idea; done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services