You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/14 16:16:06 UTC

[GitHub] [spark] gengliangwang opened a new pull request #24094: [SPARK-27162][SQL] Add new method getOriginalMap in CaseInsensitiveStringMap

gengliangwang opened a new pull request #24094: [SPARK-27162][SQL] Add new method getOriginalMap in CaseInsensitiveStringMap
URL: https://github.com/apache/spark/pull/24094
 
 
   ## What changes were proposed in this pull request?
   
   Currently, DataFrameReader/DataFrameReader supports setting Hadoop configurations via method `.option()`. 
   E.g, the following test case should be passed in both ORC V1 and V2
   ```
     class TestFileFilter extends PathFilter {
       override def accept(path: Path): Boolean = path.getParent.getName != "p=2"
     }
   
     withTempPath { dir =>
         val path = dir.getCanonicalPath
   
         val df = spark.range(2)
         df.write.orc(path + "/p=1")
         df.write.orc(path + "/p=2")
         val extraOptions = Map(
           "mapred.input.pathFilter.class" -> classOf[TestFileFilter].getName,
           "mapreduce.input.pathFilter.class" -> classOf[TestFileFilter].getName
         )
         assert(spark.read.options(extraOptions).orc(path).count() === 2)
       }
     }
   ```
   While Hadoop Configurations are case sensitive, the current data source V2 APIs are using `CaseInsensitiveStringMap` in the top level entry `TableProvider`. 
   To create Hadoop configurations correctly, I suggest adding a new method `getOriginalMap` in `CaseInsensitiveStringMap`.
   
   
   ## How was this patch tested?
   
   Unit test
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org