[GitHub] [druid] kfaraz commented on a diff in pull request #13859: Fix NPE in KinesisSupervisor#setupRecordSupplier.

["kfaraz (via GitHub)" <gi...@apache.org>]

kfaraz commented on code in PR #13859:
URL: https://github.com/apache/druid/pull/13859#discussion_r1119532052


##########
extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/supervisor/KinesisSupervisor.java:
##########
@@ -197,7 +197,7 @@ protected RecordSupplier<String, String, ByteEntity> setupRecordSupplier() throw
             ioConfig.getAwsAssumedRoleArn(),
             ioConfig.getAwsExternalId()
         ),
-        ioConfig.getRecordsPerFetch(),
+        0, // no records-per-fetch, it is not used

Review Comment:
   Maybe rephrase the comment for clarity:
   ```suggestion
           0, // need not specify recordsPerFetch as supervisor-side supplier does not fetch records
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org