You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2012/02/02 18:44:27 UTC
Review Request: SQOOP-433: Tests are failing on current 0.23 version
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3736/
-----------------------------------------------------------
Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
Summary
-------
I've tried most simple change to get it working, however I'm not sure how dirty this solution is or whether it's even acceptable.
This addresses bug SQOOP-433.
https://issues.apache.org/jira/browse/SQOOP-433
Diffs
-----
/build.xml 1239338
Diff: https://reviews.apache.org/r/3736/diff
Testing
-------
All supported versions went fine:
ant -Dhadoopversion=20 test
ant -Dhadoopversion=23 test
ant -Dhadoopversion=100 test
Thanks,
Jarek
Re: Review Request: SQOOP-433: Tests are failing on current 0.23 version
Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3736/#review4783
-----------------------------------------------------------
Thanks for the patch, Jarcec. Just one nit below.
/build.xml
<https://reviews.apache.org/r/3736/#comment10515>
It would be nice if you could make the comment a bit clearer, something like, "Set to an empty string below due to MAPREDUCE-3736"
- Bilung
On 2012-02-02 17:44:27, Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3736/
> -----------------------------------------------------------
>
> (Updated 2012-02-02 17:44:27)
>
>
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
>
>
> Summary
> -------
>
> I've tried most simple change to get it working, however I'm not sure how dirty this solution is or whether it's even acceptable.
>
>
> This addresses bug SQOOP-433.
> https://issues.apache.org/jira/browse/SQOOP-433
>
>
> Diffs
> -----
>
> /build.xml 1239338
>
> Diff: https://reviews.apache.org/r/3736/diff
>
>
> Testing
> -------
>
> All supported versions went fine:
>
> ant -Dhadoopversion=20 test
> ant -Dhadoopversion=23 test
> ant -Dhadoopversion=100 test
>
>
> Thanks,
>
> Jarek
>
>
Re: Review Request: SQOOP-433: Tests are failing on current 0.23 version
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3736/#review4801
-----------------------------------------------------------
Ship it!
+1
- Arvind
On 2012-02-03 06:07:51, Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3736/
> -----------------------------------------------------------
>
> (Updated 2012-02-03 06:07:51)
>
>
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
>
>
> Summary
> -------
>
> I've tried most simple change to get it working, however I'm not sure how dirty this solution is or whether it's even acceptable.
>
>
> This addresses bug SQOOP-433.
> https://issues.apache.org/jira/browse/SQOOP-433
>
>
> Diffs
> -----
>
> /build.xml 1239772
>
> Diff: https://reviews.apache.org/r/3736/diff
>
>
> Testing
> -------
>
> All supported versions went fine:
>
> ant -Dhadoopversion=20 test
> ant -Dhadoopversion=23 test
> ant -Dhadoopversion=100 test
>
>
> Thanks,
>
> Jarek
>
>
Re: Review Request: SQOOP-433: Tests are failing on current 0.23 version
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3736/
-----------------------------------------------------------
(Updated 2012-02-03 06:07:51.772929)
Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
Summary
-------
I've tried most simple change to get it working, however I'm not sure how dirty this solution is or whether it's even acceptable.
This addresses bug SQOOP-433.
https://issues.apache.org/jira/browse/SQOOP-433
Diffs (updated)
-----
/build.xml 1239772
Diff: https://reviews.apache.org/r/3736/diff
Testing
-------
All supported versions went fine:
ant -Dhadoopversion=20 test
ant -Dhadoopversion=23 test
ant -Dhadoopversion=100 test
Thanks,
Jarek
Re: Review Request: SQOOP-433: Tests are failing on current 0.23 version
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3736/
-----------------------------------------------------------
(Updated 2012-02-03 06:06:41.677466)
Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
Changes
-------
Thank you Bilung for your feedback, I've changed the comment per your suggestion.
Jarcec
Summary
-------
I've tried most simple change to get it working, however I'm not sure how dirty this solution is or whether it's even acceptable.
This addresses bug SQOOP-433.
https://issues.apache.org/jira/browse/SQOOP-433
Diffs (updated)
-----
/build.xml 1239772
Diff: https://reviews.apache.org/r/3736/diff
Testing
-------
All supported versions went fine:
ant -Dhadoopversion=20 test
ant -Dhadoopversion=23 test
ant -Dhadoopversion=100 test
Thanks,
Jarek