You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/12/02 17:25:30 UTC
Review Request 40874: Restructured comments in authorizer.proto
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40874/
-----------------------------------------------------------
Review request for mesos, Greg Mann, Michael Park, Jan Schlicht, and Till Toenshoff.
Repository: mesos
Description
-------
Upcoming modification to "authorizer.proto" (https://reviews.apache.org/r/39985/, https://reviews.apache.org/r/40345/) introduce a clear and readable pattern for ACL comments. Update existing comments to comply to that pattern.
Diffs
-----
include/mesos/authorizer/authorizer.proto 8e72003f405770f00c5d87f318a9e1a8ed7430ee
Diff: https://reviews.apache.org/r/40874/diff/
Testing
-------
Not a functional change.
Thanks,
Alexander Rukletsov
Re: Review Request 40874: Restructured comments in authorizer.proto
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40874/#review108674
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Dec. 2, 2015, 4:25 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40874/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 4:25 p.m.)
>
>
> Review request for mesos, Greg Mann, Michael Park, Jan Schlicht, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Upcoming modification to "authorizer.proto" (https://reviews.apache.org/r/39985/, https://reviews.apache.org/r/40345/) introduce a clear and readable pattern for ACL comments. Update existing comments to comply to that pattern.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.proto 8e72003f405770f00c5d87f318a9e1a8ed7430ee
>
> Diff: https://reviews.apache.org/r/40874/diff/
>
>
> Testing
> -------
>
> Not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40874: Restructured comments in authorizer.proto
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40874/#review108661
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On Dec. 2, 2015, 5:25 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40874/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 5:25 p.m.)
>
>
> Review request for mesos, Greg Mann, Michael Park, Jan Schlicht, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Upcoming modification to "authorizer.proto" (https://reviews.apache.org/r/39985/, https://reviews.apache.org/r/40345/) introduce a clear and readable pattern for ACL comments. Update existing comments to comply to that pattern.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.proto 8e72003f405770f00c5d87f318a9e1a8ed7430ee
>
> Diff: https://reviews.apache.org/r/40874/diff/
>
>
> Testing
> -------
>
> Not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40874: Restructured comments in authorizer.proto
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40874/#review108659
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Dec. 2, 2015, 4:25 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40874/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 4:25 p.m.)
>
>
> Review request for mesos, Greg Mann, Michael Park, Jan Schlicht, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Upcoming modification to "authorizer.proto" (https://reviews.apache.org/r/39985/, https://reviews.apache.org/r/40345/) introduce a clear and readable pattern for ACL comments. Update existing comments to comply to that pattern.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.proto 8e72003f405770f00c5d87f318a9e1a8ed7430ee
>
> Diff: https://reviews.apache.org/r/40874/diff/
>
>
> Testing
> -------
>
> Not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>