You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by wy...@apache.org on 2026/09/16 07:35:34 UTC
(maka) branch feat/runtime-host-rust updated (9d346833c8 -> e7a4c7c6ab)
This is an automated email from the ASF dual-hosted git repository.
M4n5ter pushed a change to branch feat/runtime-host-rust
in repository https://gitbox.apache.org/repos/asf/maka.git
from 9d346833c8 build(rust): audit dependency licenses with cargo-deny
new 59bedd3bcf fix(release): audit bundled source separately from external dependencies
new 8b9be15e6b fix(release): classify native source fixtures in source archives
new d105c87774 test(core): express archive header fixture without raw control bytes
new 9b4f96fef9 fix(release): inventory terminal control bytes in xterm source patch
new e7a4c7c6ab fix(release): include documented website assets and textual source formats
The 5 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.gitattributes | 1 +
docs/code-origin-audit.md | 6 +
docs/rust-runtime.md | 8 +-
docs/rust-runtime.zh-CN.md | 7 +-
packages/core/src/__tests__/attachments.test.ts | 5 +-
scripts/asf-license-headers.mjs | 4 +
scripts/asf-source-release.mjs | 32 +-----
scripts/asf-source-release.test.mjs | 147 +++---------------------
scripts/source-legal-inventory.test.mjs | 6 +-
9 files changed, 57 insertions(+), 159 deletions(-)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
(maka) 04/05: fix(release): inventory terminal control bytes in xterm source patch
Posted by wy...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
M4n5ter pushed a commit to branch feat/runtime-host-rust
in repository https://gitbox.apache.org/repos/asf/maka.git
commit 9b4f96fef9a757f4e96e2a4e264e47ba622df167
Author: Wang <m4...@gmail.com>
AuthorDate: Wed Sep 16 15:31:55 2026 +0800
fix(release): inventory terminal control bytes in xterm source patch
Generated-by: OpenAI Codex
---
docs/code-origin-audit.md | 1 +
1 file changed, 1 insertion(+)
diff --git a/docs/code-origin-audit.md b/docs/code-origin-audit.md
index c89596f390..e7283caa32 100644
--- a/docs/code-origin-audit.md
+++ b/docs/code-origin-audit.md
@@ -255,6 +255,7 @@ rejected even if a path is listed here.
- `crates/network/tests/fixtures/ca.pem`: generated loopback TLS test certificate; provenance is recorded in the adjacent `README.md`.
- `crates/network/tests/fixtures/localhost.pem`: generated loopback TLS test certificate; provenance is recorded in the adjacent `README.md`.
- `crates/network/tests/fixtures/localhost.key`: public test-only TLS key generated for Maka, not a deployment credential; provenance is recorded in the adjacent `README.md`.
+- `patches/@xterm+xterm+6.0.0.patch`: dependency source patch with literal terminal control characters in upstream context; attribution and the MIT license are in root `LICENSE`.
- `packages/core/src/__tests__/foreign-session.test.ts`: Apache-licensed source fixture containing a literal NUL, bidi override, and zero-width character to verify imported-session sanitization.
- `packages/runtime-host/src/protocol/artifact.ts`: Apache-licensed protocol source containing literal C0 and DEL characters in the control-character rejection expression.
- `packages/storage/src/__tests__/foreign-session-store.test.ts`: Apache-licensed storage fixture containing literal bidi and bell characters to verify durable imported-title sanitization.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
(maka) 02/05: fix(release): classify native source fixtures in source archives
Posted by wy...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
M4n5ter pushed a commit to branch feat/runtime-host-rust
in repository https://gitbox.apache.org/repos/asf/maka.git
commit 8b9be15e6b9cba903226728d2616b8bb522e68da
Author: Wang <m4...@gmail.com>
AuthorDate: Wed Sep 16 15:30:01 2026 +0800
fix(release): classify native source fixtures in source archives
Generated-by: OpenAI Codex
---
docs/code-origin-audit.md | 3 +++
scripts/asf-license-headers.mjs | 4 ++++
scripts/asf-source-release.mjs | 1 +
3 files changed, 8 insertions(+)
diff --git a/docs/code-origin-audit.md b/docs/code-origin-audit.md
index 0ee0e7451b..c89596f390 100644
--- a/docs/code-origin-audit.md
+++ b/docs/code-origin-audit.md
@@ -252,6 +252,9 @@ rejected even if a path is listed here.
- `apps/desktop/build/*.png`: contributor-submitted DMG artwork from pull request #3817; that contribution records Codex as review and verification assistance, not as the source of the artwork.
- `apps/desktop/resources/status/*.png`: the status images recorded above and reproducibly rendered by `scripts/generate-cu-status-icons.mjs`.
- `docs/images/**/*.png`: screenshots of Maka's own user interface committed as review evidence, including pull requests #3584 and #3588.
+- `crates/network/tests/fixtures/ca.pem`: generated loopback TLS test certificate; provenance is recorded in the adjacent `README.md`.
+- `crates/network/tests/fixtures/localhost.pem`: generated loopback TLS test certificate; provenance is recorded in the adjacent `README.md`.
+- `crates/network/tests/fixtures/localhost.key`: public test-only TLS key generated for Maka, not a deployment credential; provenance is recorded in the adjacent `README.md`.
- `packages/core/src/__tests__/foreign-session.test.ts`: Apache-licensed source fixture containing a literal NUL, bidi override, and zero-width character to verify imported-session sanitization.
- `packages/runtime-host/src/protocol/artifact.ts`: Apache-licensed protocol source containing literal C0 and DEL characters in the control-character rejection expression.
- `packages/storage/src/__tests__/foreign-session-store.test.ts`: Apache-licensed storage fixture containing literal bidi and bell characters to verify durable imported-title sanitization.
diff --git a/scripts/asf-license-headers.mjs b/scripts/asf-license-headers.mjs
index 168e1b8f17..8c0ab91a7d 100644
--- a/scripts/asf-license-headers.mjs
+++ b/scripts/asf-license-headers.mjs
@@ -368,6 +368,10 @@ const reviewedProvenance = new Map([
'scripts/asf-license-headers.test.mjs',
'Synthetic fixtures written to exercise the provenance markers.',
],
+ [
+ 'scripts/source-legal-inventory.test.mjs',
+ 'Maka-authored assertions quoting the upstream copyright notices required in the source release documents.',
+ ],
[
'scripts/generate-third-party-notices.mjs',
'Maka-authored generator that emits upstream copyright lines into THIRD_PARTY_NOTICES.txt. The copyright it names is its output, not its own.',
diff --git a/scripts/asf-source-release.mjs b/scripts/asf-source-release.mjs
index 76b2355adf..aaf5dd5a44 100644
--- a/scripts/asf-source-release.mjs
+++ b/scripts/asf-source-release.mjs
@@ -120,6 +120,7 @@ const textSourceBasenames = new Set([
'LICENSE',
'NOTICE',
'network-policy',
+ 'pre-commit',
]);
const maxCommandBuffer = 64 * 1024 * 1024;
const rejectedGpgStatuses = new Set([
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
(maka) 05/05: fix(release): include documented website assets and textual source formats
Posted by wy...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
M4n5ter pushed a commit to branch feat/runtime-host-rust
in repository https://gitbox.apache.org/repos/asf/maka.git
commit e7a4c7c6ab9232e31e2f163353c998ba2bfe1bf9
Author: Wang <m4...@gmail.com>
AuthorDate: Wed Sep 16 15:33:11 2026 +0800
fix(release): include documented website assets and textual source formats
Generated-by: OpenAI Codex
---
docs/code-origin-audit.md | 2 ++
scripts/asf-source-release.mjs | 2 ++
2 files changed, 4 insertions(+)
diff --git a/docs/code-origin-audit.md b/docs/code-origin-audit.md
index e7283caa32..f83351a741 100644
--- a/docs/code-origin-audit.md
+++ b/docs/code-origin-audit.md
@@ -247,6 +247,8 @@ non-text image must match one of these paths; executable and archive magic is
rejected even if a path is listed here.
- `.github/assets/*.png`: the README hero images rendered from the website, recorded above.
+- `website/src/assets/incubator.png`: unmodified ASF Incubator logo; upstream URL and branding use are recorded in `website/README.md`.
+- `website/src/assets/social.*.png`: site previews rendered by `website/scripts/readme-hero.mjs` from Maka's own website, like the README heroes recorded above.
- `apps/desktop/assets/icon.png`: the AI-generated application mark recorded above.
- `apps/desktop/assets/app-icons/*.png`: `mono.png` is the contributor-submitted grayscale derivative of the application mark from pull request #3431; the remaining variants are reproducibly rendered from the Apache-licensed geometry and palette in `scripts/generate-app-icons.py` and byte-checked by `scripts/generate-app-icons.test.mjs`.
- `apps/desktop/build/*.png`: contributor-submitted DMG artwork from pull request #3817; that contribution records Codex as review and verification assistance, not as the source of the artwork.
diff --git a/scripts/asf-source-release.mjs b/scripts/asf-source-release.mjs
index aaf5dd5a44..5675a353db 100644
--- a/scripts/asf-source-release.mjs
+++ b/scripts/asf-source-release.mjs
@@ -79,8 +79,10 @@ const packageDependencyFields = [
];
const bundledDependencyFields = ['bundleDependencies', 'bundledDependencies'];
const textSourceExtensions = new Set([
+ '.astro',
'.cjs',
'.css',
+ '.diff',
'.csv',
'.html',
'.js',
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
(maka) 01/05: fix(release): audit bundled source separately from external dependencies
Posted by wy...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
M4n5ter pushed a commit to branch feat/runtime-host-rust
in repository https://gitbox.apache.org/repos/asf/maka.git
commit 59bedd3bcf509f9167ece8af1ce413760e1d87fb
Author: Wang <m4...@gmail.com>
AuthorDate: Wed Sep 16 15:28:14 2026 +0800
fix(release): audit bundled source separately from external dependencies
Generated-by: OpenAI Codex
---
.gitattributes | 1 +
docs/rust-runtime.md | 8 +-
docs/rust-runtime.zh-CN.md | 7 +-
scripts/asf-source-release.mjs | 29 +------
scripts/asf-source-release.test.mjs | 147 +++++---------------------------
scripts/source-legal-inventory.test.mjs | 6 +-
6 files changed, 41 insertions(+), 157 deletions(-)
diff --git a/.gitattributes b/.gitattributes
index 9c11c3cec2..5cd407f1a7 100644
--- a/.gitattributes
+++ b/.gitattributes
@@ -13,6 +13,7 @@
# working notes are not source-release inputs.
/.claude export-ignore
/.maka-shots export-ignore
+/.github/assets/workhub-turn-admission export-ignore
/maka-proposal-zh-review.txt export-ignore
# DeepSeek Harness remains available to repository development and benchmarks,
diff --git a/docs/rust-runtime.md b/docs/rust-runtime.md
index d22423bcc4..70c28845f2 100644
--- a/docs/rust-runtime.md
+++ b/docs/rust-runtime.md
@@ -259,7 +259,13 @@ after dependency changes, run the same command with `generate` and review
[`DEPENDENCIES.rust.tsv`](../crates/cli/DEPENDENCIES.rust.tsv).
The inventory includes build dependencies but excludes dev-only dependencies;
the policy check also covers tests. It is not a binary license-text bundle.
-Native publication still requires complete upstream texts for Rust, bundled native libraries and JS.
+
+The ASF voting artifact is the source archive. Its licensing review covers bundled
+source, including the adapted Codex patch code and copied Deno telemetry files
+documented in root `LICENSE` and `NOTICE`; lockfile references are not bundled code.
+npm native packages are convenience builds of the corresponding source archive,
+not a separate source release. Keep their source version and build provenance;
+the current source audit does not certify binary licensing.
```sh
cargo fmt --all --check
diff --git a/docs/rust-runtime.zh-CN.md b/docs/rust-runtime.zh-CN.md
index 2dbca2dc91..40a05bc8d9 100644
--- a/docs/rust-runtime.zh-CN.md
+++ b/docs/rust-runtime.zh-CN.md
@@ -202,7 +202,12 @@ Rust 许可证检查沿用 [OpenDAL 的 cargo-deny 做法](https://github.com/ap
依赖变更后将 `check` 换为 `generate`，审阅
[`DEPENDENCIES.rust.tsv`](../crates/cli/DEPENDENCIES.rust.tsv)。
清单包含构建依赖，排除仅用于测试的依赖；许可证策略检查也覆盖测试。
-清单不是二进制许可证文本包；原生发布仍须收齐 Rust、内嵌原生库和 JS 的上游原文。
+清单不是二进制许可证文本包。
+
+ASF 投票制品是源码归档，许可审阅针对实际随包源码，包括根 `LICENSE` 和 `NOTICE`
+记录的 Codex 补丁改编代码与 Deno telemetry 拷贝；lockfile 引用不等于打包代码。
+npm 原生包是对应源码归档的便利构建，不是另一份源码发布；须保留来源版本和构建溯源。
+当前源码审计不作二进制许可认证。
```sh
cargo fmt --all --check
diff --git a/scripts/asf-source-release.mjs b/scripts/asf-source-release.mjs
index 975fb6492b..76b2355adf 100644
--- a/scripts/asf-source-release.mjs
+++ b/scripts/asf-source-release.mjs
@@ -583,21 +583,6 @@ function validateNodePackageInputs(candidateRoot, identity, entries) {
const rootPrefix = `${identity.rootDirectory}/`;
const readEntry = (entry) =>
readFileSync(join(candidateRoot, entry.slice(rootPrefix.length)), 'utf8');
- const noticeLicenses = new Map();
- const generatedNpmNotice = `${rootPrefix}apps/desktop/resources/licenses/npm/THIRD_PARTY_NOTICES.txt`;
- if (files.includes(generatedNpmNotice)) {
- const entry = generatedNpmNotice;
- for (const block of readEntry(entry).split(/\n={20,}\n/u)) {
- const packageKey = /^Package: (.+)$/mu.exec(block)?.[1];
- const license = /^Selected license: (.+)$/mu.exec(block)?.[1];
- if (!packageKey || !license) continue;
- const previous = noticeLicenses.get(packageKey);
- if (previous && previous !== license) {
- throw new Error(`Conflicting license inventory for ${packageKey}: ${previous}, ${license}`);
- }
- noticeLicenses.set(packageKey, license);
- }
- }
const lockEntries = files.filter((name) =>
/\/(?:package-lock|npm-shrinkwrap)\.json$/u.test(name),
@@ -694,17 +679,9 @@ function validateNodePackageInputs(candidateRoot, identity, entries) {
}
continue;
}
- const name = dependency.name ?? lockPath.slice(lockPath.lastIndexOf('node_modules/') + 13);
- const version = dependency.version;
- const packageKey = version ? `${name}@${version}` : undefined;
- const license =
- (packageKey ? noticeLicenses.get(packageKey) : undefined) ?? dependency.license;
- if (!license) {
- throw new Error(
- `Cannot safely classify ${name}${version ? `@${version}` : ''} in ${entry}`,
- );
- }
- validateReleaseLicense(license, `${name}${version ? `@${version}` : ''} in ${entry}`);
+ // Registry entries describe separately downloaded dependencies, not code
+ // bundled in this source archive. Binary notices are not source authority.
+ // Included workspace manifests are checked above; node_modules is forbidden.
}
}
}
diff --git a/scripts/asf-source-release.test.mjs b/scripts/asf-source-release.test.mjs
index 4387d008ff..39c6aa3b39 100644
--- a/scripts/asf-source-release.test.mjs
+++ b/scripts/asf-source-release.test.mjs
@@ -149,73 +149,44 @@ describe('ASF source release verification', () => {
);
});
- test('rejects Category X dependencies from a nested package lockfile', async () => {
+ test('distinguishes downloaded dependency metadata from bundled source licenses', async () => {
const fixture = createFixtureCandidate({
- 'tools/runtime/package.json': `${JSON.stringify({ name: 'runtime', private: true, license: 'Apache-2.0' })}\n`,
- 'tools/runtime/package-lock.json': `${JSON.stringify({
- lockfileVersion: 3,
+ 'tools/runtime/package.json': `${JSON.stringify({
name: 'runtime',
- packages: {
- '': { name: 'runtime', license: 'Apache-2.0' },
- 'node_modules/category-x-runtime': {
- version: '1.0.0',
- license: 'LGPL-3.0-or-later',
- },
- },
- })}\n`,
- });
- try {
- await assert.rejects(
- () => verifySourceCandidate({ archivePath: fixture.archivePath }),
- /Category X.*category-x-runtime.*LGPL-3\.0-or-later/,
- );
- } finally {
- fixture.cleanup();
- }
- });
-
- test('accepts a classified dependency from a nested package lockfile', async () => {
- const fixture = createFixtureCandidate({
- 'tools/source/package.json': `${JSON.stringify({
- dependencies: { 'source-helper': '1.0.0' },
- name: 'source',
- private: true,
+ license: 'Apache-2.0',
+ dependencies: { 'external-runtime': '1.0.0', 'unknown-runtime': '1.0.0' },
})}\n`,
- 'tools/source/package-lock.json': `${JSON.stringify({
+ 'tools/runtime/package-lock.json': `${JSON.stringify({
lockfileVersion: 3,
- name: 'source',
packages: {
- '': { name: 'source', license: 'Apache-2.0' },
- 'node_modules/source-helper': { version: '1.0.0', license: 'MIT' },
+ '': { name: 'runtime', license: 'Apache-2.0' },
+ 'node_modules/external-runtime': { version: '1.0.0', license: 'LGPL-3.0-or-later' },
+ 'node_modules/unknown-runtime': { version: '1.0.0' },
},
})}\n`,
+ 'apps/desktop/resources/licenses/npm/THIRD_PARTY_NOTICES.txt':
+ 'Package: external-runtime@1.0.0\nSelected license: GPL-3.0-only\n',
});
try {
await assert.doesNotReject(() => verifySourceCandidate({ archivePath: fixture.archivePath }));
} finally {
fixture.cleanup();
}
- });
- test('rejects an unclassified dependency from a nested package lockfile', async () => {
- const fixture = createFixtureCandidate({
- 'tools/unknown/package.json': `${JSON.stringify({ name: 'unknown', private: true, license: 'Apache-2.0' })}\n`,
- 'tools/unknown/package-lock.json': `${JSON.stringify({
- lockfileVersion: 3,
- name: 'unknown',
- packages: {
- '': { name: 'unknown', license: 'Apache-2.0' },
- 'node_modules/unknown-runtime': { version: '1.0.0' },
- },
- })}\n`,
+ const bundled = createFixtureCandidate({
+ 'vendor/runtime/package.json': JSON.stringify({
+ name: 'external-runtime',
+ version: '1.0.0',
+ license: 'LGPL-3.0-or-later',
+ }),
});
try {
await assert.rejects(
- () => verifySourceCandidate({ archivePath: fixture.archivePath }),
- /Cannot safely classify unknown-runtime@1\.0\.0.*tools\/unknown\/package-lock\.json/,
+ () => verifySourceCandidate({ archivePath: bundled.archivePath }),
+ /Category X.*vendor\/runtime\/package\.json/,
);
} finally {
- fixture.cleanup();
+ bundled.cleanup();
}
});
@@ -261,86 +232,6 @@ describe('ASF source release verification', () => {
}
});
- test('does not accept arbitrary notice files as dependency license authority', async () => {
- const fixture = createFixtureCandidate({
- 'tools/runtime/THIRD_PARTY_NOTICES.txt':
- 'Package: unknown-runtime@1.0.0\nSelected license: MIT\n',
- 'tools/runtime/package-lock.json': `${JSON.stringify({
- lockfileVersion: 3,
- packages: {
- '': { name: 'runtime' },
- 'node_modules/unknown-runtime': { version: '1.0.0' },
- },
- })}\n`,
- 'tools/runtime/package.json': `${JSON.stringify({
- dependencies: { 'unknown-runtime': '1.0.0' },
- license: 'Apache-2.0',
- name: 'runtime',
- private: true,
- })}\n`,
- });
- try {
- await assert.rejects(
- () => verifySourceCandidate({ archivePath: fixture.archivePath }),
- /Cannot safely classify unknown-runtime@1\.0\.0/,
- );
- } finally {
- fixture.cleanup();
- }
- });
-
- test('uses the generated npm notice as the dependency license authority', async () => {
- const fixture = createFixtureCandidate({
- 'apps/desktop/resources/licenses/npm/THIRD_PARTY_NOTICES.txt':
- 'Package: source-helper@1.0.0\nSelected license: MIT\n',
- 'tools/source/package-lock.json': `${JSON.stringify({
- lockfileVersion: 3,
- packages: {
- '': { name: 'source' },
- 'node_modules/source-helper': { version: '1.0.0' },
- },
- })}\n`,
- 'tools/source/package.json': `${JSON.stringify({
- dependencies: { 'source-helper': '1.0.0' },
- name: 'source',
- private: true,
- })}\n`,
- });
- try {
- await assert.doesNotReject(() => verifySourceCandidate({ archivePath: fixture.archivePath }));
- } finally {
- fixture.cleanup();
- }
- });
-
- test('does not let lock metadata override a Category X generated notice', async () => {
- const fixture = createFixtureCandidate({
- 'apps/desktop/resources/licenses/npm/THIRD_PARTY_NOTICES.txt':
- 'Package: disguised-runtime@1.0.0\nSelected license: GPL-3.0-only\n',
- 'tools/runtime/package-lock.json': `${JSON.stringify({
- lockfileVersion: 3,
- packages: {
- '': { name: 'runtime' },
- 'node_modules/disguised-runtime': { license: 'MIT', version: '1.0.0' },
- },
- })}\n`,
- 'tools/runtime/package.json': `${JSON.stringify({
- dependencies: { 'disguised-runtime': '1.0.0' },
- license: 'Apache-2.0',
- name: 'runtime',
- private: true,
- })}\n`,
- });
- try {
- await assert.rejects(
- () => verifySourceCandidate({ archivePath: fixture.archivePath }),
- /Category X.*disguised-runtime.*GPL-3\.0-only/,
- );
- } finally {
- fixture.cleanup();
- }
- });
-
test('rejects lock links without a candidate-owned workspace target', async () => {
const fixture = createFixtureCandidate({
'tools/runtime/package-lock.json': `${JSON.stringify({
diff --git a/scripts/source-legal-inventory.test.mjs b/scripts/source-legal-inventory.test.mjs
index 466e32d8e3..3925a49042 100644
--- a/scripts/source-legal-inventory.test.mjs
+++ b/scripts/source-legal-inventory.test.mjs
@@ -32,9 +32,13 @@ test('root release documents describe the source candidate', async () => {
]);
assert.equal(
notice,
- 'Apache Maka (incubating)\nCopyright 2026 The Apache Software Foundation\n\nThis product includes software developed at\nThe Apache Software Foundation (https://www.apache.org/).\n',
+ 'Apache Maka (incubating)\nCopyright 2026 The Apache Software Foundation\n\nThis product includes software developed at\nThe Apache Software Foundation (https://www.apache.org/).\n\nThis product includes portions of OpenAI Codex.\nCopyright 2025 OpenAI\n',
);
assert.match(license, /apps\/desktop\/src\/renderer\/public\/THIRD_PARTY_LICENSES\.txt/);
+ assert.match(license, /OpenAI Codex apply-patch \(adapted source\)/);
+ assert.match(license, /crates\/apply-patch\/SOURCE\.md/);
+ assert.match(license, /Deno telemetry TypeScript sources \(unmodified\)/);
+ assert.match(license, /Copyright 2018-2026 the Deno authors/);
const patches = (await readdir(join(root, 'patches'))).filter((name) => name.endsWith('.patch'));
for (const patch of patches) assert.ok(license.includes(patch), patch);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
(maka) 03/05: test(core): express archive header fixture without raw control bytes
Posted by wy...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
M4n5ter pushed a commit to branch feat/runtime-host-rust
in repository https://gitbox.apache.org/repos/asf/maka.git
commit d105c87774529f46cae1a7594af6aaecaddcddf3
Author: Wang <m4...@gmail.com>
AuthorDate: Wed Sep 16 15:31:15 2026 +0800
test(core): express archive header fixture without raw control bytes
Generated-by: OpenAI Codex
---
packages/core/src/__tests__/attachments.test.ts | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/packages/core/src/__tests__/attachments.test.ts b/packages/core/src/__tests__/attachments.test.ts
index c4c2ba59ca..1f471b63da 100644
--- a/packages/core/src/__tests__/attachments.test.ts
+++ b/packages/core/src/__tests__/attachments.test.ts
@@ -137,7 +137,8 @@ describe('resolveAttachmentMimeType (content-first precedence)', () => {
test('keeps a non-image document claim so real document kinds still resolve', () => {
const docx = 'application/vnd.openxmlformats-officedocument.wordprocessingml.document';
- assert.equal(resolveAttachmentMimeType(Buffer.from('PK'), docx, 'notes.docx'), docx);
- assert.equal(resolveAttachmentMimeType(Buffer.from('PK'), undefined, 'notes.docx'), docx);
+ const zipHeader = Buffer.from([0x50, 0x4b, 0x03, 0x04]);
+ assert.equal(resolveAttachmentMimeType(zipHeader, docx, 'notes.docx'), docx);
+ assert.equal(resolveAttachmentMimeType(zipHeader, undefined, 'notes.docx'), docx);
});
});
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org