You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/07/30 11:43:59 UTC
[GitHub] [incubator-doris] HappenLee opened a new pull request #4222: [Spill To Disk][4/6] Partition Aggregation Node Support Spill to disk in big query
HappenLee opened a new pull request #4222:
URL: https://github.com/apache/incubator-doris/pull/4222
## Proposed changes
1. Remove MemTracker in ReservationTracker, the men limit in bufferpool will be replace by MemTracker in BufferedBlockMgr2
2. Replace BufferedTupleStream3 by BufferedTupleStream2 in partition hash table, the mem alloc in hash table still use buffer pool tracker by buffreblockmgr.
3. Replace BufferedTupleStream3 by BufferedTupleStream2 in PartitionAggregationNode, Support Spill to disk in big query.
issue:#3926
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on #ISSUE, and have described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] If this change need a document change, I have updated the document
- [x] Any dependent changes have been merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wutiangan commented on a change in pull request #4222: [Spill To Disk][4/6] Partition Aggregation Node Support Spill to disk in big query
Posted by GitBox <gi...@apache.org>.
wutiangan commented on a change in pull request #4222:
URL: https://github.com/apache/incubator-doris/pull/4222#discussion_r464271514
##########
File path: be/src/exec/partitioned_hash_table.h
##########
@@ -25,10 +25,10 @@
#include "codegen/doris_ir.h"
#include "common/logging.h"
#include "common/compiler_util.h"
-#include "runtime/buffered_tuple_stream3.h"
-#include "runtime/buffered_tuple_stream3.inline.h"
#include "runtime/bufferpool/buffer_pool.h"
#include "runtime/bufferpool/suballocator.h"
+#include "runtime/buffered_tuple_stream2.h"
+#include "runtime/buffered_tuple_stream2.inline.h"
Review comment:
old import sequence is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wutiangan commented on a change in pull request #4222: [Spill To Disk][4/6] Partition Aggregation Node Support Spill to disk in big query
Posted by GitBox <gi...@apache.org>.
wutiangan commented on a change in pull request #4222:
URL: https://github.com/apache/incubator-doris/pull/4222#discussion_r464271076
##########
File path: be/src/exec/partitioned_hash_table.cc
##########
@@ -520,17 +543,26 @@ Status PartitionedHashTable::ResizeBuckets(
}
num_buckets_ = num_buckets;
- allocator_->Free(move(bucket_allocation_));
+ auto free_bytes = allocator_->Free(move(bucket_allocation_));
+ state_->block_mgr2()->release_memory(block_mgr_client_, free_bytes);
+
bucket_allocation_ = std::move(new_allocation);
buckets_ = reinterpret_cast<Bucket*>(bucket_allocation_->data());
*got_memory = true;
return Status::OK();
}
bool PartitionedHashTable::GrowNodeArray(Status* status) {
+ auto allocate_bytes = allocator_->ComputeAllocateBufferSize(DATA_PAGE_SIZE);
+ if (!state_->block_mgr2()->consume_memory(block_mgr_client_, allocate_bytes)) {
+ return false;
Review comment:
3 space?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org