You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2017/11/23 18:21:51 UTC

svn commit: r1816180 - in /ofbiz/ofbiz-framework/trunk: applications/accounting/webapp/accounting/WEB-INF/ applications/content/webapp/content/WEB-INF/ applications/manufacturing/webapp/manufacturing/WEB-INF/ applications/marketing/webapp/marketing/WEB...

Author: jleroux
Date: Thu Nov 23 18:21:51 2017
New Revision: 1816180

URL: http://svn.apache.org/viewvc?rev=1816180&view=rev
Log:
Improved: Replace request-redirect w/ no redirect-param attribute by 
request-redirect-no-param
(OFBIZ-9997)

This follows the discussion at http://markmail.org/message/sbfdlhntdzziqeyz


Modified:
    ofbiz/ofbiz-framework/trunk/applications/accounting/webapp/accounting/WEB-INF/controller.xml
    ofbiz/ofbiz-framework/trunk/applications/content/webapp/content/WEB-INF/controller.xml
    ofbiz/ofbiz-framework/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/controller.xml
    ofbiz/ofbiz-framework/trunk/applications/marketing/webapp/marketing/WEB-INF/controller.xml
    ofbiz/ofbiz-framework/trunk/applications/order/webapp/ordermgr/WEB-INF/controller.xml
    ofbiz/ofbiz-framework/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml
    ofbiz/ofbiz-framework/trunk/applications/product/webapp/catalog/WEB-INF/controller.xml
    ofbiz/ofbiz-framework/trunk/applications/product/webapp/facility/WEB-INF/controller.xml
    ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml

Modified: ofbiz/ofbiz-framework/trunk/applications/accounting/webapp/accounting/WEB-INF/controller.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/webapp/accounting/WEB-INF/controller.xml?rev=1816180&r1=1816179&r2=1816180&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/accounting/webapp/accounting/WEB-INF/controller.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/accounting/webapp/accounting/WEB-INF/controller.xml Thu Nov 23 18:21:51 2017
@@ -194,7 +194,7 @@ under the License.
     <request-map uri="updateInvoiceItem">
         <security https="true" auth="true"/>
         <event type="service-multi" invoke="updateInvoiceItem"/>
-        <response name="success" type="request-redirect" value="listInvoiceItems"/>
+        <response name="success" type="request-redirect-no-param" value="listInvoiceItems"/>
         <response name="error" type="view" value="listInvoiceItems"/>
     </request-map>
     <request-map uri="removeInvoiceItem">
@@ -1093,7 +1093,7 @@ under the License.
     <request-map uri="updateBudgetItem">
         <security https="true" auth="true"/>
         <event type="service-multi" invoke="updateBudgetItem"/>
-        <response name="success" type="request-redirect" value="EditBudgetItems"/>
+        <response name="success" type="request-redirect-no-param" value="EditBudgetItems"/>
         <response name="error" type="view" value="EditBudgetItems"/>
     </request-map>
     <request-map uri="removeBudgetItem">

Modified: ofbiz/ofbiz-framework/trunk/applications/content/webapp/content/WEB-INF/controller.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/content/webapp/content/WEB-INF/controller.xml?rev=1816180&r1=1816179&r2=1816180&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/content/webapp/content/WEB-INF/controller.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/content/webapp/content/WEB-INF/controller.xml Thu Nov 23 18:21:51 2017
@@ -1810,19 +1810,19 @@ under the License.
     <request-map uri="updateDocumentTree">
         <security auth="true" https="true"/>
         <event invoke="updateContent" type="service"/>
-        <response name="success" type="request-redirect" value="navigateContent"/>
+        <response name="success" type="request-redirect-no-param" value="navigateContent"/>
         <response name="error" type="view" value="navigateContent"/>
     </request-map>
     <request-map uri="removeDocumentFromTree">
         <security auth="true" https="true"/>
         <event invoke="removeContentAssoc" path="" type="service"/>
-        <response name="success" type="request-redirect" value="navigateContent"/>
+        <response name="success" type="request-redirect-no-param" value="navigateContent"/>
         <response name="error" type="view" value="navigateContent"/>
     </request-map>
     <request-map uri="addDocumentToTree">
         <security auth="true" https="true"/>
         <event invoke="createDocument" path="component://content/minilang/content/ContentEvents.xml" type="simple"/>
-        <response name="success" type="request-redirect" value="navigateContent"/>
+        <response name="success" type="request-redirect-no-param" value="navigateContent"/>
         <response name="error" type="request" value="navigateContent"/>
     </request-map>
     <request-map uri="showContent">

Modified: ofbiz/ofbiz-framework/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/controller.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/controller.xml?rev=1816180&r1=1816179&r2=1816180&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/controller.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/controller.xml Thu Nov 23 18:21:51 2017
@@ -449,7 +449,7 @@ under the License.
     <request-map uri="DeleteProductManufacturingRule">
         <security https="true" auth="true"/>
         <event type="service" invoke="deleteProductManufacturingRule"/>
-        <response name="success" type="request-redirect" value="EditProductManufacturingRules"/>
+        <response name="success" type="request-redirect-no-param" value="EditProductManufacturingRules"/>
         <response name="error" type="request-redirect" value="EditProductManufacturingRules"/>
     </request-map>
 

Modified: ofbiz/ofbiz-framework/trunk/applications/marketing/webapp/marketing/WEB-INF/controller.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/marketing/webapp/marketing/WEB-INF/controller.xml?rev=1816180&r1=1816179&r2=1816180&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/marketing/webapp/marketing/WEB-INF/controller.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/marketing/webapp/marketing/WEB-INF/controller.xml Thu Nov 23 18:21:51 2017
@@ -301,7 +301,7 @@ under the License.
     <request-map uri="importContactListParties">
         <security https="true" auth="true"/>
         <event type="simple" path="component://marketing/minilang/marketing/contact/ContactListEvents.xml" invoke="importContactListParties"/>
-        <response name="success" type="request-redirect" value="FindImportContactListParties"/>
+        <response name="success" type="request-redirect-no-param" value="FindImportContactListParties"/>
         <response name="error" type="request-redirect" value="FindImportContactListParties"/>
     </request-map>
     <request-map uri="contactListOptOut" track-serverhit="false" track-visit="false">

Modified: ofbiz/ofbiz-framework/trunk/applications/order/webapp/ordermgr/WEB-INF/controller.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/webapp/ordermgr/WEB-INF/controller.xml?rev=1816180&r1=1816179&r2=1816180&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/order/webapp/ordermgr/WEB-INF/controller.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/order/webapp/ordermgr/WEB-INF/controller.xml Thu Nov 23 18:21:51 2017
@@ -95,61 +95,61 @@ under the License.
     <request-map uri="massApproveOrders">
         <security https="true" auth="true"/>
         <event type="service" path="" invoke="massChangeOrderApproved"/>
-        <response name="success" type="request-redirect" value="findorders"/>
+        <response name="success" type="request-redirect-no-param" value="findorders"/>
         <response name="error" type="view" value="findorders"/>
     </request-map>
     <request-map uri="massProcessOrders">
         <security https="true" auth="true"/>
         <event type="service" path="" invoke="massProcessOrders"/>
-        <response name="success" type="request-redirect" value="findorders"/>
+        <response name="success" type="request-redirect-no-param" value="findorders"/>
         <response name="error" type="view" value="findorders"/>
     </request-map>
     <request-map uri="massHoldOrders">
         <security https="true" auth="true"/>
         <event type="service" path="" invoke="massHoldOrders"/>
-        <response name="success" type="request-redirect" value="findorders"/>
+        <response name="success" type="request-redirect-no-param" value="findorders"/>
         <response name="error" type="view" value="findorders"/>
     </request-map>
     <request-map uri="massCancelOrders">
         <security https="true" auth="true"/>
         <event type="service" path="" invoke="massCancelOrders"/>
-        <response name="success" type="request-redirect" value="findorders"/>
+        <response name="success" type="request-redirect-no-param" value="findorders"/>
         <response name="error" type="view" value="findorders"/>
     </request-map>
     <request-map uri="massCancelRemainingPurchaseOrderItems">
         <security https="true" auth="true"/>
         <event type="service" path="" invoke="massCancelRemainingPurchaseOrderItems"/>
-        <response name="success" type="request-redirect" value="findorders"/>
+        <response name="success" type="request-redirect-no-param" value="findorders"/>
         <response name="error" type="view" value="findorders"/>
     </request-map>
     <request-map uri="massRejectOrders">
         <security https="true" auth="true"/>
         <event type="service" path="" invoke="massRejectOrders"/>
-        <response name="success" type="request-redirect" value="findorders"/>
+        <response name="success" type="request-redirect-no-param" value="findorders"/>
         <response name="error" type="view" value="findorders"/>
     </request-map>
     <request-map uri="massQuickShipOrders">
         <security https="true" auth="true"/>
         <event type="service" path="" invoke="massQuickShipOrders"/>
-        <response name="success" type="request-redirect" value="findorders"/>
+        <response name="success" type="request-redirect-no-param" value="findorders"/>
         <response name="error" type="view" value="findorders"/>
     </request-map>
     <request-map uri="massPickOrders">
         <security https="true" auth="true"/>
         <event type="service" path="" invoke="massPickOrders"/>
-        <response name="success" type="request-redirect" value="findorders"/>
+        <response name="success" type="request-redirect-no-param" value="findorders"/>
         <response name="error" type="view" value="findorders"/>
     </request-map>
     <request-map uri="massPrintOrders">
         <security https="true" auth="true"/>
         <event type="service" path="" invoke="massPrintOrders"/>
-        <response name="success" type="request-redirect" value="findorders"/>
+        <response name="success" type="request-redirect-no-param" value="findorders"/>
         <response name="error" type="view" value="findorders"/>
     </request-map>
     <request-map uri="massCreateFileForOrders">
         <security https="true" auth="true"/>
         <event type="service" path="" invoke="massCreateFileForOrders"/>
-        <response name="success" type="request-redirect" value="findorders"/>
+        <response name="success" type="request-redirect-no-param" value="findorders"/>
         <response name="error" type="view" value="findorders"/>
     </request-map>
 

Modified: ofbiz/ofbiz-framework/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml?rev=1816180&r1=1816179&r2=1816180&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml Thu Nov 23 18:21:51 2017
@@ -360,7 +360,7 @@ under the License.
     <request-map uri="createEmployee">
         <security https="true" auth="true"/>
         <event type="simple" path="component://party/minilang/user/UserEvents.xml" invoke="createEmployee"/>
-        <response name="success" type="request-redirect" value="viewprofile"/>
+        <response name="success" type="request-redirect-no-param" value="viewprofile"/>
         <response name="error" type="view" value="NewEmployee"/>
     </request-map>
 
@@ -384,7 +384,7 @@ under the License.
     <request-map uri="createPartyGroup">
         <security https="true" auth="true"/>
         <event type="service" path="" invoke="createPartyGroup"/>
-        <response name="success" type="request-redirect" value="viewprofile"/>
+        <response name="success" type="request-redirect-no-param" value="viewprofile"/>
         <response name="error" type="view" value="EditPartyGroup"/>
     </request-map>
     <request-map uri="updatePartyGroup">
@@ -464,7 +464,7 @@ under the License.
     <request-map uri="createCustRequest">
         <security https="true" auth="true"/>
         <event type="service" invoke="createCustRequest"/>
-        <response name="success" type="request-redirect" value="viewprofile"/>
+        <response name="success" type="request-redirect-no-param" value="viewprofile"/>
         <response name="error" type="request-redirect" value="viewprofile"/>
     </request-map>
     <request-map uri="newrequest">

Modified: ofbiz/ofbiz-framework/trunk/applications/product/webapp/catalog/WEB-INF/controller.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/webapp/catalog/WEB-INF/controller.xml?rev=1816180&r1=1816179&r2=1816180&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/product/webapp/catalog/WEB-INF/controller.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/product/webapp/catalog/WEB-INF/controller.xml Thu Nov 23 18:21:51 2017
@@ -3048,7 +3048,7 @@ under the License.
     <request-map uri="updateProductTag">
         <security https="true" auth="true"/>
         <event type="service-multi" path="" invoke="updateProductKeyword"/>
-        <response name="success" type="request-redirect" value="EditProductTag"/>
+        <response name="success" type="request-redirect-no-param" value="EditProductTag"/>
         <response name="error" type="view" value="EditProductTag"/>
     </request-map>
     <!-- end of request mappings -->

Modified: ofbiz/ofbiz-framework/trunk/applications/product/webapp/facility/WEB-INF/controller.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/webapp/facility/WEB-INF/controller.xml?rev=1816180&r1=1816179&r2=1816180&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/product/webapp/facility/WEB-INF/controller.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/product/webapp/facility/WEB-INF/controller.xml Thu Nov 23 18:21:51 2017
@@ -1139,7 +1139,7 @@ under the License.
     <request-map uri="dhlShipmentConfirm">
         <security https="true" auth="true"/>
         <event type="service" path="" invoke="dhlShipmentConfirm"/>
-        <response name="success" type="request-redirect" value="EditShipmentRouteSegments"/>
+        <response name="success" type="request-redirect-no-param" value="EditShipmentRouteSegments"/>
         <response name="error" type="view" value="EditShipmentRouteSegments"/>
     </request-map>
 
@@ -1160,7 +1160,7 @@ under the License.
     <request-map uri="fedexShipmentConfirm">
         <security https="true" auth="true"/>
         <event type="service" path="" invoke="fedexShipRequest"/>
-        <response name="success" type="request-redirect" value="EditShipmentRouteSegments"/>
+        <response name="success" type="request-redirect-no-param" value="EditShipmentRouteSegments"/>
         <response name="error" type="view" value="EditShipmentRouteSegments"/>
     </request-map>
 

Modified: ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml?rev=1816180&r1=1816179&r2=1816180&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml (original)
+++ ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml Thu Nov 23 18:21:51 2017
@@ -64,7 +64,7 @@ under the License.
     <request-map uri="logout">
         <security https="true" auth="true"/>
         <event type="java" path="org.apache.ofbiz.webapp.control.LoginWorker" invoke="logout"/>
-        <response name="success" type="request-redirect" value="main"/>
+        <response name="success" type="request-redirect-no-param" value="main"/>
         <response name="error" type="view" value="main"/>
     </request-map>
     <request-map uri="forgotPassword">