You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "pvary (via GitHub)" <gi...@apache.org> on 2025/05/19 12:31:38 UTC
Re: [PR] Flink: Dynamic Iceberg Sink: Add dynamic writer and committer [iceberg]
pvary commented on code in PR #13080:
URL: https://github.com/apache/iceberg/pull/13080#discussion_r2095604890
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/CommitSummary.java:
##########
@@ -19,13 +19,14 @@
package org.apache.iceberg.flink.sink;
import java.util.Arrays;
+import java.util.List;
import java.util.NavigableMap;
import java.util.concurrent.atomic.AtomicLong;
import org.apache.iceberg.io.WriteResult;
import org.apache.iceberg.relocated.com.google.common.base.MoreObjects;
import org.apache.iceberg.util.ScanTaskUtil;
-class CommitSummary {
+public class CommitSummary {
Review Comment:
Is this still an `@Internal` class?
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/DeltaManifests.java:
##########
@@ -23,7 +23,7 @@
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
import org.apache.iceberg.relocated.com.google.common.collect.Lists;
-class DeltaManifests {
+public class DeltaManifests {
Review Comment:
Still `@Internal`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org