You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2020/11/10 17:00:18 UTC

[incubator-superset] branch master updated: fix: card thumbnails now always show border. (#11638)

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 3b89d23  fix: card thumbnails now always show border. (#11638)
3b89d23 is described below

commit 3b89d2307a94ad7719517ec4ee8cb67bd3189c25
Author: Evan Rusackas <ev...@preset.io>
AuthorDate: Tue Nov 10 08:58:39 2020 -0800

    fix: card thumbnails now always show border. (#11638)
    
    Co-Authored-By: Evan Rusackas <ev...@preset.io>
---
 superset-frontend/src/components/ListViewCard/ImageLoader.tsx | 5 +++--
 superset-frontend/src/components/ListViewCard/index.tsx       | 1 +
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/superset-frontend/src/components/ListViewCard/ImageLoader.tsx b/superset-frontend/src/components/ListViewCard/ImageLoader.tsx
index ba46643..6ca7ff2 100644
--- a/superset-frontend/src/components/ListViewCard/ImageLoader.tsx
+++ b/superset-frontend/src/components/ListViewCard/ImageLoader.tsx
@@ -30,8 +30,9 @@ const ImageContainer = styled.div<ImageContainerProps>`
   background-size: cover;
   background-position: center ${({ position }) => position};
   display: inline-block;
-  height: 100%;
-  width: 100%;
+  height: calc(100% - 1px);
+  width: calc(100% - 2px);
+  margin: 1px 1px 0 1px;
 `;
 interface ImageLoaderProps
   extends React.DetailedHTMLProps<
diff --git a/superset-frontend/src/components/ListViewCard/index.tsx b/superset-frontend/src/components/ListViewCard/index.tsx
index fee7d0b..5a15923 100644
--- a/superset-frontend/src/components/ListViewCard/index.tsx
+++ b/superset-frontend/src/components/ListViewCard/index.tsx
@@ -80,6 +80,7 @@ const StyledCard = styled(Card)`
 
 const Cover = styled.div`
   height: 264px;
+  border-bottom: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
   overflow: hidden;
 
   .cover-footer {