You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/11/11 09:21:36 UTC
[GitHub] [iotdb] ericpai opened a new pull request #4358: [IOTDB-1990] Fix uncheck null result by calling IReaderByTimestamp
ericpai opened a new pull request #4358:
URL: https://github.com/apache/iotdb/pull/4358
See JIRA: https://issues.apache.org/jira/browse/IOTDB-1990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #4358: [IOTDB-1990] Fix uncheck null result by calling IReaderByTimestamp
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4358:
URL: https://github.com/apache/iotdb/pull/4358#issuecomment-966176924
[](https://coveralls.io/builds/44189235)
Coverage increased (+0.03%) to 66.716% when pulling **da1b0415929913e7589cd89e9de9c6e3798ee9ec on ericpai:bugfix/iotdb-1990** into **7f936db499ed1b9c0863dcdce64799a3349a55aa on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 commented on a change in pull request #4358: [IOTDB-1990] Fix uncheck null result by calling IReaderByTimestamp
Posted by GitBox <gi...@apache.org>.
JackieTien97 commented on a change in pull request #4358:
URL: https://github.com/apache/iotdb/pull/4358#discussion_r747425985
##########
File path: server/src/main/java/org/apache/iotdb/db/query/dataset/RawQueryDataSetWithValueFilter.java
##########
@@ -118,7 +118,7 @@ private boolean cacheRowRecords() throws IOException {
// 3. use values in results to fill row record
for (int j = 0; j < cachedTimeCnt; j++) {
- if (results[j] == null) {
+ if (results == null || results[j] == null) {
Review comment:
It seems that only when `cachedTimeCnt` equals to zero, `getValuesInTimestamps` will return null. However, if `cachedTimeCnt` equals to zero, we will `return false` before here.
##########
File path: server/src/main/java/org/apache/iotdb/db/query/dataset/RawQueryDataSetWithValueFilter.java
##########
@@ -199,7 +199,7 @@ private boolean cacheRowInObjects() throws IOException {
// 3. use values in results to fill row record
for (int j = 0; j < cachedTimeCnt; j++) {
- if (results[j] != null) {
+ if (results != null && results[j] != null) {
Review comment:
Same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ericpai edited a comment on pull request #4358: [IOTDB-1990] Fix uncheck null result by calling IReaderByTimestamp
Posted by GitBox <gi...@apache.org>.
ericpai edited a comment on pull request #4358:
URL: https://github.com/apache/iotdb/pull/4358#issuecomment-966794993
@JackieTien97 I replayed this test case `IoTDBUDTFAlignByTimeQueryIT.queryWithValueFilter9` in a cluster with 3 nodes and 2 replicas. It can reappear in 100%. This is the debug screenshot. I guess the reason is that although the `cachedTimeCnt` is not empty, there's no data matching the `cachedTimeCnt` and a null result is returned. This only happens in cluster query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 merged pull request #4358: [IOTDB-1990] Fix uncheck null result by calling IReaderByTimestamp
Posted by GitBox <gi...@apache.org>.
JackieTien97 merged pull request #4358:
URL: https://github.com/apache/iotdb/pull/4358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ericpai commented on pull request #4358: [IOTDB-1990] Fix uncheck null result by calling IReaderByTimestamp
Posted by GitBox <gi...@apache.org>.
ericpai commented on pull request #4358:
URL: https://github.com/apache/iotdb/pull/4358#issuecomment-966794993
@JackieTien97 I replayed this test case `IoTDBUDTFAlignByTimeQueryIT.queryWithValueFilter9` in a cluster with 3 nodes and 2 replicas. It can reappear in 100%. This is the debug screenshot. I guess the reason is that although the `cachedTimeCnt` is not empty, there's no data matched the `cachedTimeCnt` and a null result returns. This only happens in cluster query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org