[jira] [Commented] (THRIFT-2633) remove 'this is a dummy struct' structs from generated erlang

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197500#comment-14197500 ] 

Hudson commented on THRIFT-2633:
--------------------------------

SUCCESS: Integrated in Thrift #1331 (See [https://builds.apache.org/job/Thrift/1331/])
THRIFT-2633 remove 'this is a dummy struct' structs from generated erlang (roger: rev feea9477e75ed2f9d2654bda200c1cf79c1f7a31)
* compiler/cpp/src/generate/t_erl_generator.cc
* lib/erl/src/thrift_client.erl


> remove 'this is a dummy struct' structs from generated erlang
> -------------------------------------------------------------
>
>                 Key: THRIFT-2633
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2633
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Erlang - Compiler
>            Reporter: alisdair sullivan
>            Assignee: Roger Meier
>            Priority: Minor
>              Labels: erlang
>             Fix For: 0.9.2
>
>
> the erlang backend adds 'this is a dummy struct' struct_info/1 (and struct_info_ext/1) clause to generated files which is probably incorrect behavior. it should probably instead be a function clause that catches all undefined structs and returns either 'undefined' or throws a 'function_clause' error. i've supplied a patch that does the latter (as that is the current behavior if you call struct_info/1 or struct_info_ext/1 with an undefined struct name)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)