[GitHub] [netbeans] sdedic commented on a change in pull request #2982: Fixes NPE and potential lockup in tests.

[GitBox <gi...@apache.org>]

sdedic commented on a change in pull request #2982:
URL: https://github.com/apache/netbeans/pull/2982#discussion_r642512313



##########
File path: platform/openide.execution/src/org/openide/execution/ExecutionEngine.java
##########
@@ -127,13 +127,14 @@ public ExecutorTask execute(String name, Runnable run, InputOutput io) {
             private RequestProcessor.Task task;
             private int resultValue;
             private final String name;
-            private InputOutput io;
+            private final InputOutput io;

Review comment:
       Note. The field [was simply not assigned at all](https://github.com/apache/netbeans/pull/2982/files#diff-164cf44c2b7deea8554b6c153dbac61fa62df18741fe3e6fc363d8d4a576d5f9R137). Just added `final` since the constructor got the delegate, and there were no attempts to change / invalidate it. But yes, could eventually happen even that case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists