You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2016/08/12 19:34:32 UTC

[GitHub] incubator-guacamole-client pull request #55: GUACAMOLE-74: Migrate to URL-sa...

GitHub user mike-jumper opened a pull request:

    https://github.com/apache/incubator-guacamole-client/pull/55

    GUACAMOLE-74: Migrate to URL-safe share keys.

    This change switches from problematic base64 share keys to URL-safe ("base64url", as defined in [RFC 4648, Section 5](https://tools.ietf.org/html/rfc4648#section-5)) share keys. Effective key length remains the same (264-bit).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-jumper/incubator-guacamole-client share-key-format

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-guacamole-client/pull/55.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #55
    
----
commit a996cbe2812e05348e5e440cb7fe9b7a82b43bcf
Author: Michael Jumper <mj...@apache.org>
Date:   2016-08-12T19:21:13Z

    GUACAMOLE-74: Migrate to URL-safe share keys.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-client pull request #55: GUACAMOLE-74: Migrate to URL-sa...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-guacamole-client/pull/55


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---