You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "snuyanzin (via GitHub)" <gi...@apache.org> on 2025/09/28 13:22:52 UTC
[PR] [FLINK-31499][table] Move SqlCreateTable conversion logic to SqlCreateTableConverter and make it more generic [flink]
snuyanzin opened a new pull request, #27059:
URL: https://github.com/apache/flink/pull/27059
## What is the purpose of the change
This is mostly refactoring PR generalizing the logic across different create table related convertes
## Brief change log
converters
## Verifying this change
This change is already covered by existing tests
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): ( no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? ( no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31499][table] Move SqlCreateTable conversion logic to SqlCreateTableConverter and make it more generic [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #27059:
URL: https://github.com/apache/flink/pull/27059#issuecomment-3343364490
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3e79183ff611b5cb3117e23a03b36d9ae0aedc5b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3e79183ff611b5cb3117e23a03b36d9ae0aedc5b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3e79183ff611b5cb3117e23a03b36d9ae0aedc5b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31499][table] Move SqlCreateTable conversion logic to SqlCreateTableConverter and make it more generic [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin merged PR #27059:
URL: https://github.com/apache/flink/pull/27059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31499][table] Move SqlCreateTable conversion logic to SqlCreateTableConverter and make it more generic [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #27059:
URL: https://github.com/apache/flink/pull/27059#discussion_r2385812736
##########
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlReplaceTableAs.java:
##########
@@ -73,36 +69,14 @@
* AS SELECT * FROM base_table;
* }</pre>
*/
-public class SqlReplaceTableAs extends SqlCreate implements ExtendedSqlNode {
+public class SqlReplaceTableAs extends SqlCreateTable implements ExtendedSqlNode {
Review Comment:
don't know why it wasn't like that, however based on list of fields and functionality it seems to be logical
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31499][table] Move SqlCreateTable conversion logic to SqlCreateTableConverter and make it more generic [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #27059:
URL: https://github.com/apache/flink/pull/27059#discussion_r2385809199
##########
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java:
##########
@@ -63,10 +63,6 @@ public class SqlCreateTable extends SqlCreate implements ExtendedSqlNode {
private final List<SqlTableConstraint> tableConstraints;
- public SqlDistribution getDistribution() {
- return distribution;
- }
-
Review Comment:
moved below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31499][table] Move SqlCreateTable conversion logic to SqlCreateTableConverter and make it more generic [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #27059:
URL: https://github.com/apache/flink/pull/27059#issuecomment-3344217218
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org