You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "acvictor (via GitHub)" <gi...@apache.org> on 2026/04/24 07:05:25 UTC
[PR] [VL] Move glog initialization before first LOG() call in VeloxBackend::init [gluten]
acvictor opened a new pull request, #11983:
URL: https://github.com/apache/gluten/pull/11983
## What changes are proposed in this pull request?
`LOG(INFO)` was called before `google::InitGoogleLogging()`, which is undefined behavior. This PR moves glog setup to immediately after `backendConf_` is available, ensuring all subsequent `LOG()` calls are safe.
## How was this patch tested?
Exisitng UTs
## Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Move glog initialization before first LOG() call in VeloxBackend::init [gluten]
Posted by "acvictor (via GitHub)" <gi...@apache.org>.
acvictor merged PR #11983:
URL: https://github.com/apache/gluten/pull/11983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Move glog initialization before first LOG() call in VeloxBackend::init [gluten]
Posted by "acvictor (via GitHub)" <gi...@apache.org>.
acvictor commented on PR #11983:
URL: https://github.com/apache/gluten/pull/11983#issuecomment-4312319564
> LGTM! but I dont really realize what UB will happened, have you encounter such case?
I got one crash while printing configs during testing that I could not reproduce. This was the only explanation I could see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org