You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/01/20 03:56:42 UTC
[GitHub] [guacamole-client] mike-jumper opened a new pull request #463:
GUACAMOLE-930: Remove unnecessary $scope.$apply().
mike-jumper opened a new pull request #463: GUACAMOLE-930: Remove unnecessary $scope.$apply().
URL: https://github.com/apache/guacamole-client/pull/463
As noted on #453, a `[$rootScope:infdig]` error occurs on recent builds from git which prevents the language selection field from rendering. This is a regression from [GUACAMOLE-630](https://issues.apache.org/jira/browse/GUACAMOLE-630), specifically from commit 93ba19ac26a3509878023886eee0140bcf3face9, which changed the way that the injectors for fields are produced.
This change removes the `$apply()` call entirely, as it is unnecessary. Promises returned by the `$q` and `$http` services, including the promise returned by `languageService.getLanguages()`, will implicitly `$apply()` when needed.
It's not fully clear why this was not a problem before this commit. It may be that the way field injectors were produced in the past somehow did not satisfy the conditions which would normally result in an automatic `$apply()` for promises returned by `$http`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] necouchman merged pull request #463:
GUACAMOLE-930: Remove unnecessary $scope.$apply().
Posted by GitBox <gi...@apache.org>.
necouchman merged pull request #463: GUACAMOLE-930: Remove unnecessary $scope.$apply().
URL: https://github.com/apache/guacamole-client/pull/463
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services