[jira] [Updated] (CASSANDRA-14819) Certain table metrics not released when table is dropped.

["Caleb Rackliffe (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CASSANDRA-14819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Caleb Rackliffe updated CASSANDRA-14819:
----------------------------------------
    Resolution: Duplicate
        Status: Resolved  (was: Open)

CASSANDRA-14888 includes fixes for these metric releases.

> Certain table metrics not released when table is dropped.
> ---------------------------------------------------------
>
>                 Key: CASSANDRA-14819
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14819
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Observability/Metrics
>            Reporter: Adam Zegelin
>            Priority: Low
>         Attachments: release-metrics.patch
>
>
> The following metrics are not released when a table is dropped:
>  * {{CasCommitLatency}}
>  * {{CasCommitTotalLatency}}
>  * {{CasPrepareLatency}}
>  * {{CasPrepareTotalLatency}}
>  * {{CasProposeLatency}}
>  * {{CasProposeTotalLatency}}
>  * {{ReadRepairRequests}}
>  * {{ShortReadProtectionRequests}}
>  
> This can be verified by inspecting the list of exported MBeans after creating a table then dropping it.
> The result is that if a table with the same name is re-created then the above metrics wont be updated - internally a {{javax.management.InstanceAlreadyExistsException}} is thrown by the {{MBeanServer}} when the new table's metric is registered, but this exception is silently ignored by {{org.apache.cassandra.metrics.CassandraMetricsRegistry#registerMBean}}
> The above metrics were added in 2014/2015, so this issue probably affects all versions released since then.
>  
> Attached a patch that releases/removes the metrics when the table is dropped.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org