You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2023/01/04 03:01:37 UTC
[GitHub] [skywalking] dashanji opened a new issue, #10228: [Feature] [Infra-e2e] Support debugging on an existing kubernetes cluster and single-step debugging
dashanji opened a new issue, #10228:
URL: https://github.com/apache/skywalking/issues/10228
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
1. When using the current infra-e2e for kubernetes test locally, we find the kind cluster is repeatedly created and deleted, which will waste of time, so we can add some fields to set up the kubeconfig of an existing kubernetes cluster(kind).
2. As mentioned before, if we can debug on an existing cluster, to not affect the original cluster resources, we need to add a built-in command to collect the previous kubernetes reousces created in the previous steps and delete them.
3. To make debugging more convenient, we need to add a built-in command to support single-step debugging, which can wait for a signal from an external process, and when the signal comes, continue to the next step.
### Use case
1. Add a filed like `kubeconfig`.
```yaml
setup:
kubeconfig: ../config
steps:
...
```
2. Add a built-in command like `e2e-delete-previous-kubernetes-resources`.
```yaml
setup:
steps:
- name: xxx
command: kubectl create xxx
- name: xxx
command: kubectl apply xxx
- name: e2e-delete-previous-kubernetes-resources
```
3. Add a built-in command like `single-debugging`.
```yaml
setup:
steps:
- name: xxx
command: kubectl create xxx
- name: single-debugging
- name: xxx
command: kubectl apply xxx
- name: single-debugging
```
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #10228: [Feature] [Infra-e2e] Support debugging on an existing kubernetes cluster and single-step debugging
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #10228:
URL: https://github.com/apache/skywalking/issues/10228#issuecomment-1370788917
Looks like the proposal is all about setup phase, correct me if I'm wrong, I assumed the users' steps to set up new tests is:
- start a kubernetes cluster
- run commands to set up the environment
- verify the environment is correctly set up
- compose a kind.yaml file and use it in e2e.yaml to spin up a kubernetes cluster
- copy the commands in step 2 to e2e.yaml file
I don't recommend start directly from e2e.yaml and debug there, I recommend starting in a local cluster and run the commands locally, after verifications then move those commands into e2e.
And I assumed if users run those command in a local cluster it should be the same to copy them into the e2e.yaml file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] dashanji commented on issue #10228: [Feature] [Infra-e2e] Support debugging on an existing kubernetes cluster and single-step debugging
Posted by GitBox <gi...@apache.org>.
dashanji commented on issue #10228:
URL: https://github.com/apache/skywalking/issues/10228#issuecomment-1370815039
Yes, all points are setup phase. From my experience, the setup phase can actually be regarded as a workflow. If we already have an e2e test and the steps are very long. When one of the steps changes (such as version upgrades, etc.), I think running the original e2e is more convenient than manual execution, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #10228: [Feature] [Infra-e2e] Support debugging on an existing kubernetes cluster and single-step debugging
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #10228:
URL: https://github.com/apache/skywalking/issues/10228#issuecomment-1378126049
> Yes, that's why we need single-step debugging, we can debug a certain step to avoid twice execution(when a step failed, we need to run the e2e twice).
I meant with that ability we don't need to support running in an existing cluster, no?
I remember we had a similar request from community user but we decided not to do this because running on an existing cluster may make it troublesome when it behaves differently in CI, people may pre-install something in their local running cluster and run the e2e and it passed but it failed in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10228: [Feature] [Infra-e2e] Support debugging on an existing kubernetes cluster and single-step debugging
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #10228:
URL: https://github.com/apache/skywalking/issues/10228#issuecomment-1370442546
@kezhenxu94 @fgksgf Could you provide some suggestions here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10228: [Feature] [Infra-e2e] Support debugging on an existing kubernetes cluster and single-step debugging
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #10228:
URL: https://github.com/apache/skywalking/issues/10228#issuecomment-1378968960
Fixed by https://github.com/apache/skywalking-infra-e2e/pull/94.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] dashanji commented on issue #10228: [Feature] [Infra-e2e] Support debugging on an existing kubernetes cluster and single-step debugging
Posted by GitBox <gi...@apache.org>.
dashanji commented on issue #10228:
URL: https://github.com/apache/skywalking/issues/10228#issuecomment-1371049347
Yes, that's why we need single-step debugging, we can debug a certain step to avoid twice execution(when a step failed, we need to run the e2e twice).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #10228: [Feature] [Infra-e2e] Support debugging on an existing kubernetes cluster and single-step debugging
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #10228: [Feature] [Infra-e2e] Support debugging on an existing kubernetes cluster and single-step debugging
URL: https://github.com/apache/skywalking/issues/10228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] dashanji commented on issue #10228: [Feature] [Infra-e2e] Support debugging on an existing kubernetes cluster and single-step debugging
Posted by GitBox <gi...@apache.org>.
dashanji commented on issue #10228:
URL: https://github.com/apache/skywalking/issues/10228#issuecomment-1378180621
Thanks for these details, I don't think the two conflict. The main reason for adding this feature is to save time for pulling or loading images. Also, with this feature, we can use `minikube`、`k3s` etc as a test environment too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] fgksgf commented on issue #10228: [Feature] [Infra-e2e] Support debugging on an existing kubernetes cluster and single-step debugging
Posted by GitBox <gi...@apache.org>.
fgksgf commented on issue #10228:
URL: https://github.com/apache/skywalking/issues/10228#issuecomment-1370450766
1. This makes sense to me
2. I think the implementation would be complicated and hard to be general, maybe let users to control it would be more suitable, for example make `cleanup` support execute commands:
```yaml
cleanup:
steps:
- name: xxx
command: kubectl delete -f xxx
```
3. Good point, but we need a more detailed design
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #10228: [Feature] [Infra-e2e] Support debugging on an existing kubernetes cluster and single-step debugging
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #10228:
URL: https://github.com/apache/skywalking/issues/10228#issuecomment-1370977236
> Yes, all points are setup phase. From my experience, the setup phase can actually be regarded as a workflow. If we already have an e2e test and the steps are very long. When one of the steps changes (such as version upgrades, etc.), I think running the original e2e is more convenient than manual execution, what do you think?
Ok. In that case(such as upgrade versions) the proposal makes sense to me. Just curious do you know that we can leave the cluster for debugging if the e2e failed to run the commands (failed to setup the env)? In another word the e2e can be configured not to destroy the cluster if it failed to run the setup commands. You know that right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org