You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2018/09/15 19:08:52 UTC

[GitHub] spark pull request #22413: [SPARK-25425][SQL] Extra options override session...

Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22413#discussion_r217893030
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala ---
    @@ -385,6 +400,9 @@ class SimpleDataSourceV2 extends DataSourceV2 with BatchReadSupportProvider {
       }
     }
     
    +class DataSourceV2WithSessionConfigs extends SimpleDataSourceV2 with SessionConfigSupport {
    +  def keyPrefix(): String = "test"
    +}
    --- End diff --
    
    Ur, it seems that we can use the existing one.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org