You are viewing a plain text version of this content. The canonical link for it is here.
Posted to torque-dev@db.apache.org by Henning Schmiedehausen <hp...@intermeta.de> on 2003/07/09 14:49:42 UTC

Patch for Maven Torque Plugin

Hi,

to whom it may concern:

property names in maven (at least up to b9, don't know about b10) must
not contain "-". The torque plugin unfortunately contains two of these
which are promptly interpreted by jelly as xxxx.foo - bar.yyy instead
of xxxx.foo-bar.yyy

Please apply the attached patch to the torque plugin, which fixes this.

	Regards
		Henning


-- 
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen          INTERMETA GmbH
hps@intermeta.de        +49 9131 50 654 0   http://www.intermeta.de/

Java, perl, Solaris, Linux, xSP Consulting, Web Services 
freelance consultant -- Jakarta Turbine Development  -- hero for hire

--- Quote of the week: "It is pointless to tell people anything when
you know that they won't process the message." --- Jonathan Revusky

Re: Patch for Maven Torque Plugin

Posted by Daniel Rall <dl...@finemaltcoding.com>.
Jason applied Henning's patch on the 9th.  Thank Jason!

- Dan


Henning Schmiedehausen <hp...@intermeta.de> writes:

> Hi,
> 
> to whom it may concern:
> 
> property names in maven (at least up to b9, don't know about b10) must
> not contain "-". The torque plugin unfortunately contains two of these
> which are promptly interpreted by jelly as xxxx.foo - bar.yyy instead
> of xxxx.foo-bar.yyy
> 
> Please apply the attached patch to the torque plugin, which fixes this.
> 
> 	Regards
> 		Henning
> 
> 
> -- 
> Dipl.-Inf. (Univ.) Henning P. Schmiedehausen          INTERMETA GmbH
> hps@intermeta.de        +49 9131 50 654 0   http://www.intermeta.de/
> 
> Java, perl, Solaris, Linux, xSP Consulting, Web Services 
> freelance consultant -- Jakarta Turbine Development  -- hero for hire
> 
> --- Quote of the week: "It is pointless to tell people anything when
> you know that they won't process the message." --- Jonathan Revusky
> 
> Index: plugin.jelly
> ===================================================================
> RCS file: /home/cvspublic/maven/src/plugins-build/torque/plugin.jelly,v
> retrieving revision 1.6
> diff -u -b -r1.6 plugin.jelly
> --- plugin.jelly	22 May 2003 04:59:36 -0000	1.6
> +++ plugin.jelly	9 Jul 2003 12:49:27 -0000
> @@ -354,8 +354,8 @@
>            templatePath="${torque.templatePath}"
>            useClasspath="${torque.useClasspath}">
>            <fileset dir="${torque.schema.dir}"
> -            includes="${torque.schema.create-db.includes}"
> -            excludes="${torque.schema.create-db.excludes}"
> +            includes="${torque.schema.createdb.includes}"
> +            excludes="${torque.schema.createdb.excludes}"
>            />
>          </torque-data-model>
>  
> @@ -471,8 +471,8 @@
>        templatePath="${torque.templatePath}"
>        useClasspath="${torque.useClasspath}">
>        <fileset dir="${torque.schema.dir}"
> -        includes="${torque.schema.init-sql.includes}"
> -        excludes="${torque.schema.init-sql.excludes}"
> +        includes="${torque.schema.initsql.includes}"
> +        excludes="${torque.schema.initsql.excludes}"
>        />
>      </torque-sql>
>  
> Index: plugin.properties
> ===================================================================
> RCS file: /home/cvspublic/maven/src/plugins-build/torque/plugin.properties,v
> retrieving revision 1.1
> diff -u -b -r1.1 plugin.properties
> --- plugin.properties	26 Feb 2003 23:30:46 -0000	1.1
> +++ plugin.properties	9 Jul 2003 12:49:27 -0000
> @@ -183,10 +183,10 @@
>  torque.schema.sql.excludes =
>  torque.schema.doc.includes = *-schema.xml
>  torque.schema.doc.excludes =
> -torque.schema.create-db.includes = *-schema.xml
> -torque.schema.create-db.excludes =
> -torque.schema.init-sql.includes = *-schema.xml
> -torque.schema.init-sql.excludes = id-table-schema.xml
> +torque.schema.createdb.includes = *-schema.xml
> +torque.schema.createdb.excludes =
> +torque.schema.initsql.includes = *-schema.xml
> +torque.schema.initsql.excludes = id-table-schema.xml
>  torque.schema.om.includes = *-schema.xml
>  torque.schema.om.excludes = id-table-schema.xml
>  torque.schema.ojb.includes = *-schema.xml

---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org


Re: Patch for Maven Torque Plugin

Posted by Daniel Rall <dl...@finemaltcoding.com>.
Jason applied Henning's patch on the 9th.  Thank Jason!

- Dan


Henning Schmiedehausen <hp...@intermeta.de> writes:

> Hi,
> 
> to whom it may concern:
> 
> property names in maven (at least up to b9, don't know about b10) must
> not contain "-". The torque plugin unfortunately contains two of these
> which are promptly interpreted by jelly as xxxx.foo - bar.yyy instead
> of xxxx.foo-bar.yyy
> 
> Please apply the attached patch to the torque plugin, which fixes this.
> 
> 	Regards
> 		Henning
> 
> 
> -- 
> Dipl.-Inf. (Univ.) Henning P. Schmiedehausen          INTERMETA GmbH
> hps@intermeta.de        +49 9131 50 654 0   http://www.intermeta.de/
> 
> Java, perl, Solaris, Linux, xSP Consulting, Web Services 
> freelance consultant -- Jakarta Turbine Development  -- hero for hire
> 
> --- Quote of the week: "It is pointless to tell people anything when
> you know that they won't process the message." --- Jonathan Revusky
> 
> Index: plugin.jelly
> ===================================================================
> RCS file: /home/cvspublic/maven/src/plugins-build/torque/plugin.jelly,v
> retrieving revision 1.6
> diff -u -b -r1.6 plugin.jelly
> --- plugin.jelly	22 May 2003 04:59:36 -0000	1.6
> +++ plugin.jelly	9 Jul 2003 12:49:27 -0000
> @@ -354,8 +354,8 @@
>            templatePath="${torque.templatePath}"
>            useClasspath="${torque.useClasspath}">
>            <fileset dir="${torque.schema.dir}"
> -            includes="${torque.schema.create-db.includes}"
> -            excludes="${torque.schema.create-db.excludes}"
> +            includes="${torque.schema.createdb.includes}"
> +            excludes="${torque.schema.createdb.excludes}"
>            />
>          </torque-data-model>
>  
> @@ -471,8 +471,8 @@
>        templatePath="${torque.templatePath}"
>        useClasspath="${torque.useClasspath}">
>        <fileset dir="${torque.schema.dir}"
> -        includes="${torque.schema.init-sql.includes}"
> -        excludes="${torque.schema.init-sql.excludes}"
> +        includes="${torque.schema.initsql.includes}"
> +        excludes="${torque.schema.initsql.excludes}"
>        />
>      </torque-sql>
>  
> Index: plugin.properties
> ===================================================================
> RCS file: /home/cvspublic/maven/src/plugins-build/torque/plugin.properties,v
> retrieving revision 1.1
> diff -u -b -r1.1 plugin.properties
> --- plugin.properties	26 Feb 2003 23:30:46 -0000	1.1
> +++ plugin.properties	9 Jul 2003 12:49:27 -0000
> @@ -183,10 +183,10 @@
>  torque.schema.sql.excludes =
>  torque.schema.doc.includes = *-schema.xml
>  torque.schema.doc.excludes =
> -torque.schema.create-db.includes = *-schema.xml
> -torque.schema.create-db.excludes =
> -torque.schema.init-sql.includes = *-schema.xml
> -torque.schema.init-sql.excludes = id-table-schema.xml
> +torque.schema.createdb.includes = *-schema.xml
> +torque.schema.createdb.excludes =
> +torque.schema.initsql.includes = *-schema.xml
> +torque.schema.initsql.excludes = id-table-schema.xml
>  torque.schema.om.includes = *-schema.xml
>  torque.schema.om.excludes = id-table-schema.xml
>  torque.schema.ojb.includes = *-schema.xml

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: Patch for Maven Torque Plugin

Posted by "Mark H. Wilkinson" <mh...@kremvax.net>.
On Thu, 2003-07-10 at 08:57, Martin Skopp wrote:
> On Wed, 2003-07-09 at 15:14, Jason van Zyl wrote:
> > > property names in maven (at least up to b9, don't know about b10) must
> > > not contain "-". The torque plugin unfortunately contains two of these
> > > which are promptly interpreted by jelly as xxxx.foo - bar.yyy instead
> > > of xxxx.foo-bar.yyy
> Had problem with the "-" myself and IMHO it would be a nice feature to
> support "-" in prop names...

The problem is coming up with a way for the expression parser to decide
whether a.b-c.d should be interpreted as "subtract c.d from a.b" or
"find the d property of the 'b-c' property of a"? Jexl is an expression
language, not just a way to look-up property names.

I think the JSTL has moved in the direction of JavaScript, and would
allow a["b-c"].d now. Would that keep people happy? It's not the tidiest
syntax, but it doesn't break well established practices either.

-Mark.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: Patch for Maven Torque Plugin

Posted by Jason van Zyl <ja...@zenplex.com>.
On Thu, 2003-07-10 at 03:57, Martin Skopp wrote:
> On Wed, 2003-07-09 at 15:14, Jason van Zyl wrote:
> > > property names in maven (at least up to b9, don't know about b10) must
> > > not contain "-". The torque plugin unfortunately contains two of these
> > > which are promptly interpreted by jelly as xxxx.foo - bar.yyy instead
> > > of xxxx.foo-bar.yyy
> > 
> > Done.
> 
> Is that fixed in CVS head for ALL properties, Jason?

No, it was a patch specifically for torque which removed use of
properties with hyphens. This is a problem with expressions in Jexl
generally. I am very much leaning toward using an alternative syntax for
expressions and that would be the use of OGNL which just works.

> Had problem with the "-" myself and IMHO it would be a nice feature to
> support "-" in prop names...

I'm looking at altering the expression factory used by Maven to leave
Jexl expressions there because everyone uses them now and optionally add
OGNL expressions which are far more robust. I use OGNL expressions
exclusively with my Werkflow Jelly and it works fantastically.

-- 
jvz.

Jason van Zyl
jason@zenplex.com
http://tambora.zenplex.org

In short, man creates for himself a new religion of a rational
and technical order to justify his work and to be justified in it.
  
  -- Jacques Ellul, The Technological Society


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: Patch for Maven Torque Plugin

Posted by Martin Skopp <sk...@riege.de>.
On Wed, 2003-07-09 at 15:14, Jason van Zyl wrote:
> > property names in maven (at least up to b9, don't know about b10) must
> > not contain "-". The torque plugin unfortunately contains two of these
> > which are promptly interpreted by jelly as xxxx.foo - bar.yyy instead
> > of xxxx.foo-bar.yyy
> 
> Done.

Is that fixed in CVS head for ALL properties, Jason?
Had problem with the "-" myself and IMHO it would be a nice feature to
support "-" in prop names...
-- 
Martin Skopp
Riege Software International GmbH
Support: mailto:maint@riege.com, Information: http://www.riege.com
 
This email is intended to be viewed with a nonproportional font.
Public Key on http://www.keyserver.net, Key-ID: 3D4027B5
Fingerprint: 1970 C78D 9A1D 99FA 5CE4  5C0D 29E6 6A95 3D40 27B5



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: Patch for Maven Torque Plugin

Posted by "Henning P. Schmiedehausen" <hp...@intermeta.de>.
Jason van Zyl <ja...@zenplex.com> writes:

>> Please apply the attached patch to the torque plugin, which fixes this.

>Done.

Thanks.

	Regards
		Henning

-- 
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen          INTERMETA GmbH
hps@intermeta.de        +49 9131 50 654 0   http://www.intermeta.de/

Java, perl, Solaris, Linux, xSP Consulting, Web Services 
freelance consultant -- Jakarta Turbine Development  -- hero for hire

--- Quote of the week: "It is pointless to tell people anything when
you know that they won't process the message." --- Jonathan Revusky

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: Patch for Maven Torque Plugin

Posted by Jason van Zyl <ja...@zenplex.com>.
On Wed, 2003-07-09 at 08:49, Henning Schmiedehausen wrote:
> Hi,
> 
> to whom it may concern:
> 
> property names in maven (at least up to b9, don't know about b10) must
> not contain "-". The torque plugin unfortunately contains two of these
> which are promptly interpreted by jelly as xxxx.foo - bar.yyy instead
> of xxxx.foo-bar.yyy
> 
> Please apply the attached patch to the torque plugin, which fixes this.

Done.

> 	Regards
> 		Henning
-- 
jvz.

Jason van Zyl
jason@zenplex.com
http://tambora.zenplex.org

In short, man creates for himself a new religion of a rational
and technical order to justify his work and to be justified in it.
  
  -- Jacques Ellul, The Technological Society


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org