You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/06 11:21:10 UTC

[GitHub] [airflow] eladkal opened a new issue #18770: Properly handle verify parameter in TrinoHook

eladkal opened a new issue #18770:
URL: https://github.com/apache/airflow/issues/18770


   ### Body
   
   This task refers to comment left in the Hook:
   
   https://github.com/apache/airflow/blob/c9bf5f33e5d5bcbf7d31663a8571628434d7073f/airflow/providers/trino/hooks/trino.py#L96-L100
   
   The change of https://github.com/trinodb/trino-python-client/pull/31  was released in trino version 0.301.0
   
   **The task:**
   Change the code + [tests](https://github.com/apache/airflow/blob/main/tests/providers/trino/hooks/test_trino.py) to work with the verify parameter directly. It will also require setting min version for trino in `setup.py`
   
   
   ### Committer
   
   - [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk closed issue #18770: Properly handle verify parameter in TrinoHook

Posted by GitBox <gi...@apache.org>.
potiuk closed issue #18770:
URL: https://github.com/apache/airflow/issues/18770


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk closed issue #18770: Properly handle verify parameter in TrinoHook

Posted by GitBox <gi...@apache.org>.
potiuk closed issue #18770:
URL: https://github.com/apache/airflow/issues/18770


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] danarwix commented on issue #18770: Properly handle verify parameter in TrinoHook

Posted by GitBox <gi...@apache.org>.
danarwix commented on issue #18770:
URL: https://github.com/apache/airflow/issues/18770#issuecomment-936417847


   Hey :-)
   
   Working on the fix
   most of the changes are implemented and will be uploaded tomorrow :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org