You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/01/06 03:15:43 UTC
[kudu-CR] Add some path / env related helper functions
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5618
to look at the new patch set (#3).
Change subject: Add some path / env related helper functions
......................................................................
Add some path / env related helper functions
* path_util: Add SplitPath() helper function
This function provides a (theoretically) portable method of splitting
a filesystem path into its constituent components.
* env: Add GetCurrentWorkingDir() and ChangeDir()
These are functions that were missing from our Env implementation.
* env_util: Implement CreateDirsRecursively()
This function is similar in spirit to the "mkdir -p" command.
Also reordered a few includes and deleted a few lines of commented-out code.
Change-Id: Ia664708a09493923abbf2ff4e56e3d49c62cf97e
---
M src/kudu/util/env-test.cc
M src/kudu/util/env.h
M src/kudu/util/env_posix.cc
M src/kudu/util/env_util-test.cc
M src/kudu/util/env_util.cc
M src/kudu/util/env_util.h
M src/kudu/util/path_util-test.cc
M src/kudu/util/path_util.cc
M src/kudu/util/path_util.h
9 files changed, 182 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/5618/3
--
To view, visit http://gerrit.cloudera.org:8080/5618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia664708a09493923abbf2ff4e56e3d49c62cf97e
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>