You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "empiredan (via GitHub)" <gi...@apache.org> on 2023/01/30 07:38:28 UTC

[GitHub] [incubator-pegasus] empiredan opened a new issue, #1336: Feature(new_metrics): migrate replica-level metrics for write service

empiredan opened a new issue, #1336:
URL: https://github.com/apache/incubator-pegasus/issues/1336

   As is described in https://github.com/apache/incubator-pegasus/issues/1326,  since both `pegasus_server_write` and `pegasus_write_service` are derived from `replica_base`, their replica-level metrics can be attached directly to *replica* entity. `pegasus_write_service` is one of the members of `pegasus_server_write`.
   
   Following metrics are the members of `pegasus_server_write` ([pegasus_server_write.cpp](https://github.com/apache/incubator-pegasus/blob/master/src/server/pegasus_server_write.cpp)). Their variables in current source files and new types/computations in new framework are listed as below:
   
   | Variables | Types/Computations |
   | :-------: | :------------------: |
   | _pfc_recent_corrupt_write_count | increase(Counter) |
   
   <br>
   
   Following metrics are the members of `pegasus_write_service` ([pegasus_write_service.cpp](https://github.com/apache/incubator-pegasus/blob/master/src/server/pegasus_write_service.cpp)). Their variables in current source files and new types/computations in new framework are listed as below:
   
   | Variables | Types/Computations |
   | :-------: | :------------------: |
   | _pfc_put_qps | rate(Counter) |
   | _pfc_multi_put_qps | rate(Counter) |
   | _pfc_remove_qps | rate(Counter) |
   | _pfc_multi_remove_qps | rate(Counter) |
   | _pfc_check_and_set_qps | rate(Counter) |
   | _pfc_check_and_mutate_qps | rate(Counter) |
   | _pfc_put_latency | Percentile |
   | _pfc_multi_put_latency | Percentile |
   | _pfc_remove_latency | Percentile |
   | _pfc_multi_remove_latency | Percentile |
   | _pfc_incr_latency | Percentile |
   | _pfc_check_and_set_latency | Percentile |
   | _pfc_check_and_mutate_latency | Percentile |
   | _pfc_duplicate_qps | rate(Counter) |
   | _pfc_dup_time_lag | Percentile |
   | _pfc_dup_lagging_writes | increase(Counter) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] acelyc111 commented on issue #1336: Feature(new_metrics): migrate replica-level metrics for write service

Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 commented on issue #1336:
URL: https://github.com/apache/incubator-pegasus/issues/1336#issuecomment-1435710841

   @empiredan  It would be better to describe the relationship between old metric names and the new ones, then users know how to change their monitor tools.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] empiredan commented on issue #1336: Feature(new_metrics): migrate replica-level metrics for write service

Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan commented on issue #1336:
URL: https://github.com/apache/incubator-pegasus/issues/1336#issuecomment-1442047942

   > @empiredan It would be better to describe the relationship between old metric names and the new ones, then users know how to change their monitor tools.
   
   OK, I'll add both old and new names into the table. Also, I'll summarize all the changes into a big table. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org