[GitHub] [shardingsphere-on-cloud] mlycore commented on a diff in pull request #316: feat: add verify Spec && update reconcile logic

["mlycore (via GitHub)" <gi...@apache.org>]

mlycore commented on code in PR #316:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/316#discussion_r1172428707


##########
shardingsphere-operator/api/v1alpha1/shardingsphere_chaos_types.go:
##########
@@ -78,13 +80,26 @@ const (
 type ShardingSphereChaosStatus struct {
 	ChaosCondition ChaosCondition `json:"chaosCondition"`
 	Phase          Phase          `json:"phase"`
+	Result         []Result       `json:"result"`

Review Comment:
   Use plural to keep it's semantic. Please update `Result` to `Results`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org