[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10456: Upgrade h2 version from 1.x to 2.x

["xiangfu0 (via GitHub)" <gi...@apache.org>]

xiangfu0 commented on code in PR #10456:
URL: https://github.com/apache/pinot/pull/10456#discussion_r1145186511


##########
pinot-query-runtime/src/test/resources/queries/BooleanLogic.json:
##########
@@ -55,11 +55,14 @@
     },
     "queries": [
       {
-        "note": "to be postgres compatible, this should throw an exception - but various other systems (like H2 and MySQL) support this",
+        "ignored": true,
+        "note": "H2 doesn't support this",

Review Comment:
   The issue is H2 2.x version now returns exception for this type casting queries, but v2 engine still returns.
   ```
   java.lang.AssertionError: Expected error with message '.*Cannot apply '=' to arguments.*'. But instead rows were returned: [true],
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org