[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4790: Support ORDER BY for DISTINCT queries

[GitBox <gi...@apache.org>]

mayankshriv commented on a change in pull request #4790: Support ORDER BY for DISTINCT queries
URL: https://github.com/apache/incubator-pinot/pull/4790#discussion_r342563590
 
 

 ##########
 File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
 ##########
 @@ -481,10 +481,6 @@ static void validateRequest(BrokerRequest brokerRequest, int queryResponseLimit)
             // TODO: Explore if DISTINCT should be supported with GROUP BY
             throw new UnsupportedOperationException("DISTINCT with GROUP BY is currently not supported");
           }
-          if (brokerRequest.isSetOrderBy()) {
 
 Review comment:
   Is there an invalid case where we do want to through exception? For example, is there a syntactically correct but semantically incorrect query that we still want to throw exception? If so, may be we should push those checks in the complier side, as opposed to the server side.
   ```select distinct(a, b) from foo order by c, d```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org