You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/02/12 07:36:41 UTC
Review Request 43517: Speed up MasterTest.OfferTimeout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43517/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-4167
https://issues.apache.org/jira/browse/MESOS-4167
Repository: mesos
Description
-------
Speed up MasterTest.OfferTimeout.
Diffs
-----
src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303
Diff: https://reviews.apache.org/r/43517/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 43517: Speed up MasterTest.OfferTimeout.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43517/#review128383
-----------------------------------------------------------
Ship it!
I'll adjust the wording and will commit shortly.
- Alexander Rukletsov
On April 8, 2016, 3:43 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43517/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 3:43 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
>
>
> Bugs: MESOS-4167
> https://issues.apache.org/jira/browse/MESOS-4167
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up MasterTest.OfferTimeout by advance allocation interval.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 8f93fbaf2bfd66bbc144a85c0097f45c55ff3491
>
> Diff: https://reviews.apache.org/r/43517/diff/
>
>
> Testing
> -------
>
> Repeat test in CentOS 7.1
> ```
> sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.OfferTimeout" --gtest_repeat=200 --gtest_break_on_failure
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43517: Speed up MasterTest.OfferTimeout.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43517/#review127859
-----------------------------------------------------------
Bad patch!
Reviews applied: [43517, 43516, 43515, 43514]
Failed command: ./support/apply-review.sh -n -r 43515
Error:
2016-04-08 19:36:33 URL:https://reviews.apache.org/r/43515/diff/raw/ [950/950] -> "43515.patch" [1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.
Full log: https://builds.apache.org/job/mesos-reviewbot/12410/console
- Mesos ReviewBot
On April 8, 2016, 3:43 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43517/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 3:43 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
>
>
> Bugs: MESOS-4167
> https://issues.apache.org/jira/browse/MESOS-4167
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up MasterTest.OfferTimeout by advance allocation interval.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 8f93fbaf2bfd66bbc144a85c0097f45c55ff3491
>
> Diff: https://reviews.apache.org/r/43517/diff/
>
>
> Testing
> -------
>
> Repeat test in CentOS 7.1
> ```
> sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.OfferTimeout" --gtest_repeat=200 --gtest_break_on_failure
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43517: Speed up MasterTest.OfferTimeout.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43517/
-----------------------------------------------------------
(Updated April 8, 2016, 3:43 p.m.)
Review request for mesos, Alexander Rukletsov and Ben Mahler.
Bugs: MESOS-4167
https://issues.apache.org/jira/browse/MESOS-4167
Repository: mesos
Description (updated)
-------
Speed up MasterTest.OfferTimeout by advance allocation interval.
Diffs (updated)
-----
src/tests/master_tests.cpp 8f93fbaf2bfd66bbc144a85c0097f45c55ff3491
Diff: https://reviews.apache.org/r/43517/diff/
Testing (updated)
-------
Repeat test in CentOS 7.1
```
sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.OfferTimeout" --gtest_repeat=200 --gtest_break_on_failure
```
Thanks,
haosdent huang
Re: Review Request 43517: Speed up MasterTest.OfferTimeout.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43517/#review118984
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43514, 43515, 43516, 43517]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 12, 2016, 6:36 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43517/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2016, 6:36 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-4167
> https://issues.apache.org/jira/browse/MESOS-4167
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up MasterTest.OfferTimeout.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303
>
> Diff: https://reviews.apache.org/r/43517/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>