[jira] [Closed] (OFBIZ-5031) Search orders by good identification

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-5031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-5031.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 12.04
                   SVN trunk
                   Release Branch 11.04
                   Release Branch 10.04
         Assignee: Jacques Le Roux

Thanks Sergei,

Your slightly enhanced patch, minus the fix, is commited in trunk at 1493387  

I have also commited the fix in
trunk r1493393
R12.04 r1493393
R11.04 r1493399
R10.04 r1493394



                
> Search orders by good identification
> ------------------------------------
>
>                 Key: OFBIZ-5031
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5031
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sergei Biletnikov
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04
>
>         Attachments: OFBIZ-5031_Search_orders_by_good_identification.patch, screenshot-1.jpg
>
>
> I propose to extend the search mask for the search orders forms with the "Good identification" field.
> A thing which can be improved is :
> <option value="">Any good identification</option>   (in "applications/order/webapp/ordermgr/order/findOrders.ftl")
> adding : "Any good identification" to the resource bundle.
> Also, I found a bug which exists from 10.04 at least:
> search orders by shipment method does not work properly, because:
> {noformat}
> applications/order/webapp/ordermgr/WEB-INF/actions/order/FindOrders.groovy
>  currentCarrierShipmentMethod = delegator.findByAnd("CarrierShipmentMethod", [partyId : carrierPartyId, shipmentMethodTypeId : shipmentMethodTypeId], null, false);
> is not correct, the result is the list, so the remedy is simple:
>  currentCarrierShipmentMethod = EntityUtil.getFirst(delegator.findByAnd("CarrierShipmentMethod", [partyId : carrierPartyId, shipmentMethodTypeId : shipmentMethodTypeId], null, false));
> {noformat}
> My patch has this fix, but it is necessary to make this fix for other OFBiz version.
> Kind regards,
> Sergei

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira