You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/09/26 12:30:08 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #6178: [AIRFLOW-5546] Fix DataprocClusterCreateOperator

potiuk commented on a change in pull request #6178: [AIRFLOW-5546] Fix DataprocClusterCreateOperator
URL: https://github.com/apache/airflow/pull/6178#discussion_r328584703
 
 

 ##########
 File path: airflow/gcp/operators/dataproc.py
 ##########
 @@ -485,7 +485,20 @@ def _usable_existing_cluster_present(self, service):
 
             if existing_status == 'RUNNING':
                 self.log.info('Cluster exists and is already running. Using it.')
-                return True
+                return existing_cluster
 
 Review comment:
   I agree it's strange to do it this way. It should be consistently one type. Waiting for the refactor :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services