[GitHub] [cloudstack] soreana commented on pull request #5799: HAproxy based load balancer customization

[GitBox <gi...@apache.org>]

soreana commented on PR #5799:
URL: https://github.com/apache/cloudstack/pull/5799#issuecomment-1167364780

   > > @weizhouapache I have a suggestion for #5799. We can test it gradually, like what we did when we developed it. We can have a branch named `HAproxy-LoadBalancer` in the community. I will port all the changes from #5799 to `HAproxy-LoadBalancer` one by one. When satisfied with its quality, we can merge it to the `main` branch. That way, it would be far easier for community members to test it.
   > > This feature could be part of it, too.
   > 
   > @soreana Each PR can be merged only if there are at least 2 approvals and all smoke tests pass. Most users use official release. If someone want to test a feature, they can build and test the specific branch, it is not needed to merge it into main.
   
   @weizhouapache, Let's discuss it here and not spamming their pr :)
   
   I completely agree with you, but the problem is that this pr didn't get the enough attention. I thought with that approach I can get the community members to review and test +300 line code changes rather than a scary +3,949 −86 😄 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org