You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by nareshpr <gi...@git.apache.org> on 2017/03/20 07:26:30 UTC
[GitHub] incubator-carbondata pull request #674: [CARBONDATA-795]rename table is chan...
GitHub user nareshpr opened a pull request:
https://github.com/apache/incubator-carbondata/pull/674
[CARBONDATA-795]rename table is changing provided db to current db
When user trigger rename table command not on current database, table is getting renamed from provided db to current db.
eg., alter table testdb.test1 rename to testdb.test2
Assume current db is default,
Above query is renaming the table from testdb.test1 to default.test2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nareshpr/incubator-carbondata renametablefix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/674.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #674
----
commit 0642d2664526836a97ffec901ddcba811cfbeebe
Author: nareshpr <pr...@gmail.com>
Date: 2017-03-20T07:11:32Z
rename table is changing provided db to current db
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #674: [CARBONDATA-795]rename table is changing pr...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/674
Build Failed with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1230/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #674: [CARBONDATA-795]rename table is changing pr...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/674
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #674: [CARBONDATA-795]rename table is changing pr...
Posted by nareshpr <gi...@git.apache.org>.
Github user nareshpr commented on the issue:
https://github.com/apache/incubator-carbondata/pull/674
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #674: [CARBONDATA-795]rename table is changing pr...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/674
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1240/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #674: [CARBONDATA-795]rename table is chan...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/674
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #674: [CARBONDATA-795]rename table is changing pr...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/674
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1233/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #674: [CARBONDATA-795]rename table is chan...
Posted by nareshpr <gi...@git.apache.org>.
GitHub user nareshpr reopened a pull request:
https://github.com/apache/incubator-carbondata/pull/674
[CARBONDATA-795]rename table is changing provided db to current db
When user trigger rename table command not on current database, table is getting renamed from provided db to current db.
eg., alter table testdb.test1 rename to testdb.test2
Assume current db is default,
Above query is renaming the table from testdb.test1 to default.test2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nareshpr/incubator-carbondata renametablefix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/674.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #674
----
commit e41f66eb83162370a785a6df37cd17a6cc7a3be2
Author: nareshpr <pr...@gmail.com>
Date: 2017-03-20T07:11:32Z
rename table is changing provided db to current db
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #674: [CARBONDATA-795]rename table is changing pr...
Posted by nareshpr <gi...@git.apache.org>.
Github user nareshpr commented on the issue:
https://github.com/apache/incubator-carbondata/pull/674
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #674: [CARBONDATA-795]rename table is chan...
Posted by nareshpr <gi...@git.apache.org>.
Github user nareshpr closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/674
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #674: [CARBONDATA-795]rename table is chan...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/674#discussion_r106864706
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommands.scala ---
@@ -174,7 +175,7 @@ private[sql] case class AlterTableRenameTable(alterTableRenameModel: AlterTableR
CarbonEnv.get.carbonMetastore.removeTableFromMetadata(oldDatabaseName, oldTableName)
sparkSession.sharedState.externalCatalog.asInstanceOf[HiveExternalCatalog].client
.runSqlHive(
- s"ALTER TABLE $oldDatabaseName.$oldTableName RENAME TO $newTableName")
+ s"ALTER TABLE $oldDatabaseName.$oldTableName RENAME TO $newDatabaseName.$newTableName")
--- End diff --
Change this to oldDatabaseName
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #674: [CARBONDATA-795]rename table is changing pr...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/674
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1237/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---