You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/03/27 17:29:09 UTC
[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #617: Fixes HUDI-9 : Check precondition minInstantsToKeep > cleanerCommitsR…
vinothchandar commented on a change in pull request #617: Fixes HUDI-9 : Check precondition minInstantsToKeep > cleanerCommitsR…
URL: https://github.com/apache/incubator-hudi/pull/617#discussion_r269683323
##########
File path: hoodie-client/src/main/java/com/uber/hoodie/config/HoodieCompactionConfig.java
##########
@@ -101,9 +101,9 @@
private static final String DEFAULT_INLINE_COMPACT = "false";
private static final String DEFAULT_INLINE_COMPACT_NUM_DELTA_COMMITS = "1";
private static final String DEFAULT_CLEANER_FILE_VERSIONS_RETAINED = "3";
- private static final String DEFAULT_CLEANER_COMMITS_RETAINED = "24";
- private static final String DEFAULT_MAX_COMMITS_TO_KEEP = String.valueOf(128);
- private static final String DEFAULT_MIN_COMMITS_TO_KEEP = String.valueOf(96);
+ private static final String DEFAULT_CLEANER_COMMITS_RETAINED = "10";
Review comment:
@n3nash once you are happy with defaults, I ll merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services