You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by MaxGekk <gi...@git.apache.org> on 2018/09/25 15:54:42 UTC

[GitHub] spark pull request #22503: [SPARK-25493][SQL] Use auto-detection for CRLF in...

Github user MaxGekk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22503#discussion_r220251783
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala ---
    @@ -212,6 +212,11 @@ class CSVOptions(
         settings.setEmptyValue(emptyValueInRead)
         settings.setMaxCharsPerColumn(maxCharsPerColumn)
         settings.setUnescapedQuoteHandling(UnescapedQuoteHandling.STOP_AT_DELIMITER)
    +
    +    if (multiLine) {
    +      settings.setLineSeparatorDetectionEnabled(true)
    --- End diff --
    
    Would be simple just `settings.setLineSeparatorDetectionEnabled(multiLine)` or `settings.setLineSeparatorDetectionEnabled(multiLine == true)`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org