You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/07/19 16:26:48 UTC
[GitHub] [druid] isandeep41 commented on a change in pull request #11462: fixes possible data truncation
isandeep41 commented on a change in pull request #11462:
URL: https://github.com/apache/druid/pull/11462#discussion_r672450301
##########
File path: core/src/main/java/org/apache/druid/math/expr/Function.java
##########
@@ -218,7 +218,13 @@ protected ExprEval eval(long param)
protected ExprEval eval(double param)
{
- return eval((long) param);
+ long param2;
+ if (param > Long.MIN_VALUE && param < Long.MAX_VALUE) {
+ param2 = (long) param;
Review comment:
thanks for pointing, have removed unnecessary variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org