You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/22 18:38:05 UTC

[GitHub] [incubator-nuttx] patacongo opened a new pull request #5587: Garbage configuration setting in EFM32 code

patacongo opened a new pull request #5587:
URL: https://github.com/apache/incubator-nuttx/pull/5587


   ## Summary
   
   arch/arm/src/efm32/efm32_start.c:
   
         /* For the case of the separate user-/kernel-space build, perform whatever
          * platform specific initialization of the user memory is required.
         * Normally this just means initializing the user space .data and .bss
          * segments.
          */
   
       #ifdef CONFIG_NUTTX_KERNEL
         efm32_userspace();
         showprogress('E');
       #endif
   
   But there is no CONFIG_NUTTX_KERNEL configuration setting.  Comparing this to other architectures it is clear this should be
   
       #ifdef CONFIG_BUILD_PROTECTED
   
   ## Impact
   
   None except for any protected mode EFM32 builds.  If there were any this, this would fix them.  There aren't.
   
   ## Testing
   
   There is no obvious way to test this other than by getting out a EFM32 board, creating and debugging a protected mode build, and verifying that .bss and .data are initialized.  Not worth the effort.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5587: Garbage configuration setting in EFM32 code

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5587:
URL: https://github.com/apache/incubator-nuttx/pull/5587


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org