You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/02 18:19:29 UTC
[GitHub] [airflow] kaxil opened a new pull request #8075: Add backticks in
IMAGES.rst command description
kaxil opened a new pull request #8075: Add backticks in IMAGES.rst command description
URL: https://github.com/apache/airflow/pull/8075
@potiuk Close this PR if you are already covering it in follow up PR
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #8075: Add
backticks in IMAGES.rst command description
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #8075: Add backticks in IMAGES.rst command description
URL: https://github.com/apache/airflow/pull/8075#discussion_r402566076
##########
File path: IMAGES.rst
##########
@@ -34,7 +34,7 @@ The images are named as follows:
where:
-* BRANCH_OR_TAG - branch or tag used when creating the image. Examples: master, v1-10-test, 1.10.10
+* ``BRANCH_OR_TAG`` - branch or tag used when creating the image. Examples: master, v1-10-test, 1.10.10
The ``master`` and ``v1-10-test`` labels are built from branches so they change over time. the 1.10.* and in
the future ``2.*`` labels are build from git tags and they are "fixed" once built.
* PYTHON_MAJOR_MINOR_VERSION - version of python used to build the image. Examples: 3.5, 3.7
Review comment:
cc @potiuk can you add this please in your follow up PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8075: Add
backticks in IMAGES.rst command description
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #8075: Add backticks in IMAGES.rst command description
URL: https://github.com/apache/airflow/pull/8075#discussion_r402564624
##########
File path: IMAGES.rst
##########
@@ -34,7 +34,7 @@ The images are named as follows:
where:
-* BRANCH_OR_TAG - branch or tag used when creating the image. Examples: master, v1-10-test, 1.10.10
+* ``BRANCH_OR_TAG`` - branch or tag used when creating the image. Examples: master, v1-10-test, 1.10.10
The ``master`` and ``v1-10-test`` labels are built from branches so they change over time. the 1.10.* and in
the future ``2.*`` labels are build from git tags and they are "fixed" once built.
* PYTHON_MAJOR_MINOR_VERSION - version of python used to build the image. Examples: 3.5, 3.7
Review comment:
``
* ``PYTHON_MAJOR_MINOR_VERSION`` - version of python used to build the image. Examples: 3.5, 3.7
``
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #8075: Add
backticks in IMAGES.rst command description
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #8075: Add backticks in IMAGES.rst command description
URL: https://github.com/apache/airflow/pull/8075#discussion_r402761225
##########
File path: IMAGES.rst
##########
@@ -34,7 +34,7 @@ The images are named as follows:
where:
-* BRANCH_OR_TAG - branch or tag used when creating the image. Examples: master, v1-10-test, 1.10.10
+* ``BRANCH_OR_TAG`` - branch or tag used when creating the image. Examples: master, v1-10-test, 1.10.10
The ``master`` and ``v1-10-test`` labels are built from branches so they change over time. the 1.10.* and in
the future ``2.*`` labels are build from git tags and they are "fixed" once built.
* PYTHON_MAJOR_MINOR_VERSION - version of python used to build the image. Examples: 3.5, 3.7
Review comment:
I already have it :)? I just was totally out-of-steam yesterday :). Will do some follow-ups today :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #8075: Add backticks in
IMAGES.rst command description
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #8075: Add backticks in IMAGES.rst command description
URL: https://github.com/apache/airflow/pull/8075
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8075: Add
backticks in IMAGES.rst command description
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #8075: Add backticks in IMAGES.rst command description
URL: https://github.com/apache/airflow/pull/8075#discussion_r402564624
##########
File path: IMAGES.rst
##########
@@ -34,7 +34,7 @@ The images are named as follows:
where:
-* BRANCH_OR_TAG - branch or tag used when creating the image. Examples: master, v1-10-test, 1.10.10
+* ``BRANCH_OR_TAG`` - branch or tag used when creating the image. Examples: master, v1-10-test, 1.10.10
The ``master`` and ``v1-10-test`` labels are built from branches so they change over time. the 1.10.* and in
the future ``2.*`` labels are build from git tags and they are "fixed" once built.
* PYTHON_MAJOR_MINOR_VERSION - version of python used to build the image. Examples: 3.5, 3.7
Review comment:
* ``PYTHON_MAJOR_MINOR_VERSION`` - version of python used to build the image. Examples: 3.5, 3.7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services