You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by jodastephen <gi...@git.apache.org> on 2017/10/27 12:04:20 UTC
[GitHub] commons-lang pull request #304: Fix DateUtilsTest to work reliably on Java 9
GitHub user jodastephen opened a pull request:
https://github.com/apache/commons-lang/pull/304
Fix DateUtilsTest to work reliably on Java 9
Fixes failures due to MST time-zone not being formatted as "MST"
Also sets and unsets time-zones in finally blocks
to avoid pollution global state when tests fail
See [LANG-1362](https://issues.apache.org/jira/browse/LANG-1362)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jodastephen/commons-lang date-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/304.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #304
----
commit 0a6d43fc284b9a085d1b72ca38011187c761321e
Author: Stephen Colebourne <st...@opengamma.com>
Date: 2017-10-27T11:56:28Z
Fix DateUtilsTest to work reliably on Java 9
Fixes failures due to MST time-zone not being formatted as "MST"
Also sets and unsets time-zones in finally blocks
to avoid pollution global state when tests fail
----
---
[GitHub] commons-lang issue #304: Fix DateUtilsTest to work reliably on Java 9
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/commons-lang/pull/304
The current git master build OK for me with 'mvn clean verify' and Oracle Java 9.0.1.
---
[GitHub] commons-lang issue #304: Fix DateUtilsTest to work reliably on Java 9
Posted by jodastephen <gi...@git.apache.org>.
Github user jodastephen commented on the issue:
https://github.com/apache/commons-lang/pull/304
Test failure looks like a timing issue unrelated to this PR
---
[GitHub] commons-lang issue #304: Fix DateUtilsTest to work reliably on Java 9
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/304
@garydgregory For me too and the build on travis with java 9 has been sucessfully running for months now.
This seems to be a locale related thing. I can replicated the 8 test failures by adding `-Duser.country=GB -Duser.language=en` to surefire `argLine`.
---
[GitHub] commons-lang pull request #304: Fix DateUtilsTest to work reliably on Java 9
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/304
---
[GitHub] commons-lang issue #304: Fix DateUtilsTest to work reliably on Java 9
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/304
[](https://coveralls.io/builds/13919695)
Coverage remained the same at 95.163% when pulling **0a6d43fc284b9a085d1b72ca38011187c761321e on jodastephen:date-tests** into **7a3ca8598dc4e830337dd938f2ad501a1e4049fe on apache:master**.
---