You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/09 10:09:00 UTC
[jira] [Commented] (LANG-1339) Some classes depend on the java.desktop profile

    [ https://issues.apache.org/jira/browse/LANG-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079524#comment-16079524 ] 

ASF GitHub Bot commented on LANG-1339:
--------------------------------------

GitHub user kinow opened a pull request:

    https://github.com/apache/commons-lang/pull/275

    [WIP] LANG-1339: replace java.beans.PropertyListener by java.util.Observable

    For discussion, regarding [LANG-1339](https://issues.apache.org/jira/browse/LANG-1339) (TL;DR: remove depedency on java.desktop from [lang], preparing for Java 9). Thought having some code to discuss would be helpful.
    
    This pull request contains a possible solution, where java.beans.{PropertyChangeListener,PropertyChangeListener} are replaced by java.util.{Observer,Observable}.
    
    Users would still have the same feature, but alas binary compatibility would not be kept. So perhaps this could be in a 4.x release. The other methods are deprecated in the next 3.x releases, and we remove the dependency to java.desktop on 4.x, and also offer a Java9 module with no dependency java.desktop.
    
    Would this be a viable alternative?
    
    Cheers
    Bruno

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kinow/commons-lang LANG-1339

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/275.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #275
    
----
commit 0ba4ea983b0e2ffdffd102b23921292c3c92d3ac
Author: Bruno P. Kinoshita <ki...@apache.org>
Date:   2017-07-09T10:01:06Z

    LANG-1339: replace java.beans.PropertyListener by java.util.Observable

----


> Some classes depend on the java.desktop profile
> -----------------------------------------------
>
>                 Key: LANG-1339
>                 URL: https://issues.apache.org/jira/browse/LANG-1339
>             Project: Commons Lang
>          Issue Type: Task
>            Reporter: Benedikt Ritter
>              Labels: Java9
>             Fix For: 3.7
>
>
> Commons Lang currently depends on java.desktop. This seems like an unnecessary heavy dependency for a library like Commons Lang. We need to find a way to fix this, without breaking bc. For more information see https://lists.apache.org/thread.html/8db8ec4aa1bdeae3d471ca4f46a21dc7da1a4c6933e1810238b72283@%3Cdev.commons.apache.org%3E



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)