[Impala-ASF-CR] IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names.

["Pranay Singh (Code Review)" <ge...@cloudera.org>]

Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/9147 )

Change subject: IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names.
......................................................................


Patch Set 9:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9147/9/fe/src/main/java/org/apache/impala/catalog/KuduTable.java
File fe/src/main/java/org/apache/impala/catalog/KuduTable.java:

http://gerrit.cloudera.org:8080/#/c/9147/9/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@321
PS9, Line 321:       List<ColumnDef> PrimaryKeyColumnDefs, List<KuduPartitionParam> partitionParams) {
> style: PrimaryKeyColumnDefs -> primaryKeyColumnDefs
Done


http://gerrit.cloudera.org:8080/#/c/9147/9/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@327
PS9, Line 327:     for (ColumnDef pk_coldef: PrimaryKeyColumnDefs) {
> pk_coldef -> pkColDef
Done


http://gerrit.cloudera.org:8080/#/c/9147/9/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test
File testdata/workloads/functional-query/queries/QueryTest/kudu_create.test:

http://gerrit.cloudera.org:8080/#/c/9147/9/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test@290
PS9, Line 290: ====
> revert
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/9147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica1c8ec1544339e9e80733a7a0c78594e0a727d2
Gerrit-Change-Number: 9147
Gerrit-PatchSet: 9
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pranay Singh
Gerrit-Comment-Date: Thu, 01 Feb 2018 00:03:56 +0000
Gerrit-HasComments: Yes