You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2021/11/18 06:50:19 UTC
[GitHub] [bigtop] iwasakims opened a new pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
iwasakims opened a new pull request #832:
URL: https://github.com/apache/bigtop/pull/832
https://issues.apache.org/jira/browse/BIGTOP-3601
We can upgrade to recent Kafka requiring ZooKeeper 3.5 now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] elukey commented on pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
elukey commented on pull request #832:
URL: https://github.com/apache/bigtop/pull/832#issuecomment-1001214183
Tested building (with the above patch) on Debian 11 x86, ran smoke tests, all succeeded.
Side note - Kafka 2.8.0 ships with KIP-500, that should allow running Kafka without Zookeeper (see https://issues.apache.org/jira/browse/KAFKA-9119). We could add a smoke test for this use case, to test with/without Zookeeper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] afsanjar commented on pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
afsanjar commented on pull request #832:
URL: https://github.com/apache/bigtop/pull/832#issuecomment-974106821
Don't we need to bump the Zookeeper version as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] elukey commented on pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
elukey commented on pull request #832:
URL: https://github.com/apache/bigtop/pull/832#issuecomment-999813585
I am currently unable to build due to the following (I guess temporary error):
```
A problem occurred configuring root project 'kafka-2.8.1'.
> Could not resolve all artifacts for configuration ':classpath'.
> Could not resolve org.eclipse.jgit:org.eclipse.jgit:latest.release.
Required by:
project : > org.ajoberstar.grgit:grgit-core:4.1.0
> Failed to list versions for org.eclipse.jgit:org.eclipse.jgit.
> Unable to load Maven meta-data from https://dl.bintray.com/content/netflixoss/external-gradle-plugins/org/eclipse/jgit/org.eclipse.jgit/maven-metadata.xml.
> Could not get resource 'https://dl.bintray.com/content/netflixoss/external-gradle-plugins/org/eclipse/jgit/org.eclipse.jgit/maven-metadata.xml'.
> Could not GET 'https://dl.bintray.com/content/netflixoss/external-gradle-plugins/org/eclipse/jgit/org.eclipse.jgit/maven-metadata.xml'. Received status code 502 from server: Bad Gateway
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
iwasakims commented on pull request #832:
URL: https://github.com/apache/bigtop/pull/832#issuecomment-1002306410
> I found this kafka issue that seem to remove the dl.bintray.com problem. I adapted the patch for the 2.8 branch:
@elukey I got another error after applying the patch. How about using existing gradlew here and addressing the issue in follow-up JIRAs?
```
$ gradle wrapper
FAILURE: Build failed with an exception.
* Where:
Build file '/home/centos/srcs/kafka/build.gradle' line: 146
* What went wrong:
A problem occurred evaluating root project 'kafka'.
> org/eclipse/jgit/storage/file/FileRepositoryBuilder has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] elukey commented on a change in pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
elukey commented on a change in pull request #832:
URL: https://github.com/apache/bigtop/pull/832#discussion_r782217874
##########
File path: bigtop-packages/src/rpm/kafka/SPECS/kafka.spec
##########
@@ -66,6 +66,7 @@ Source2: install_%{kafka_name}.sh
Source3: kafka-server.svc
Source4: init.d.tmpl
Source6: kafka.default
+#BIGTOP_PATCH_FILES
Review comment:
Just to be sure, are those comments needed or added while testing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on a change in pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
iwasakims commented on a change in pull request #832:
URL: https://github.com/apache/bigtop/pull/832#discussion_r775135570
##########
File path: bigtop-packages/src/common/kafka/do-component-build
##########
@@ -27,8 +27,6 @@ BUILD_OPTS="-Divy.home=${HOME}/.ivy2 -Dsbt.ivy.home=${HOME}/.ivy2 -Duser.home=${
# http://maven.40175.n5.nabble.com/Not-finding-artifact-in-local-repo-td3727753.html
export MAVEN_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=512m"
-gradle wrapper
Review comment:
It just fails dut to unavailable resources. The cause might be version mismatch of gradle. (bigtop_toolchain install 5.6.2.)
Since [generated wrapper script](https://github.com/apache/kafka/blob/2.8.1/gradlew) is provided, we don't need to generate it on our own.
```
$ gradle wrapper
Starting a Gradle Daemon, 1 busy Daemon could not be reused, use --status for details
FAILURE: Build failed with an exception.
* What went wrong:
A problem occurred configuring root project 'kafka'.
> Could not resolve all artifacts for configuration ':classpath'.
> Could not resolve org.eclipse.jgit:org.eclipse.jgit:latest.release.
Required by:
project : > org.ajoberstar.grgit:grgit-core:4.1.0
> Failed to list versions for org.eclipse.jgit:org.eclipse.jgit.
> Unable to load Maven meta-data from https://dl.bintray.com/content/netflixoss/external-gradle-plugins/org/eclipse/jgit/org.eclipse.jgit/maven-metadata.xml.
> Could not get resource 'https://dl.bintray.com/content/netflixoss/external-gradle-plugins/org/eclipse/jgit/org.eclipse.jgit/maven-metadata.xml'.
> Could not GET 'https://dl.bintray.com/content/netflixoss/external-gradle-plugins/org/eclipse/jgit/org.eclipse.jgit/maven-metadata.xml'. Received status code 502 from server: Bad Gateway
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 18s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] elukey commented on a change in pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
elukey commented on a change in pull request #832:
URL: https://github.com/apache/bigtop/pull/832#discussion_r774116235
##########
File path: bigtop-packages/src/common/kafka/do-component-build
##########
@@ -27,8 +27,6 @@ BUILD_OPTS="-Divy.home=${HOME}/.ivy2 -Dsbt.ivy.home=${HOME}/.ivy2 -Duser.home=${
# http://maven.40175.n5.nabble.com/Not-finding-artifact-in-local-repo-td3727753.html
export MAVEN_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=512m"
-gradle wrapper
Review comment:
To get more info - why is this command dropped?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] elukey commented on pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
elukey commented on pull request #832:
URL: https://github.com/apache/bigtop/pull/832#issuecomment-1002461657
@iwasakims I am fine with any approach, I proposed the above patch because I still get a HTTP 502 for https://dl.bintray.com/content/netflixoss/external-gradle-plugins/org/eclipse/jgit/org.eclipse.jgit/maven-metadata.xml and my test builds on Debian fail consistently. Does it work for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on a change in pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
iwasakims commented on a change in pull request #832:
URL: https://github.com/apache/bigtop/pull/832#discussion_r782293068
##########
File path: bigtop-packages/src/rpm/kafka/SPECS/kafka.spec
##########
@@ -66,6 +66,7 @@ Source2: install_%{kafka_name}.sh
Source3: kafka-server.svc
Source4: init.d.tmpl
Source6: kafka.default
+#BIGTOP_PATCH_FILES
Review comment:
We need the comments for rpm packaging to apply `patch*.diff` files. Bigtop replaces the `#BIGTOP_PATCH_FILES` in spec file with list of patches (and replaces `#BIGTOP_PATCH_COMMANDS` with command lines applying them. https://github.com/apache/bigtop/blob/master/packages.gradle#L590-L607
While we have similar trick for deb packaging, we usually don't need modify sources of each package.
https://github.com/apache/bigtop/blob/master/packages.gradle#L438-L447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
iwasakims commented on pull request #832:
URL: https://github.com/apache/bigtop/pull/832#issuecomment-1009860035
@elukey I got successful `./gradlew kafka-pkg` by additional fix on both CentOS 8 and Debian 11. Could you check this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on a change in pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
iwasakims commented on a change in pull request #832:
URL: https://github.com/apache/bigtop/pull/832#discussion_r775136310
##########
File path: bigtop-tests/smoke-tests/kafka/TestKafkaSmoke.groovy
##########
@@ -32,20 +32,7 @@ class TestKafkaSmoke {
static Shell sh = new Shell("/bin/bash -s");
static final String KAFKA_HOME = "/usr/lib/kafka"
- static final String KAFKA_CONFIG = KAFKA_HOME + "/config/server.properties "
static final String KAFKA_TOPICS = KAFKA_HOME + "/bin/kafka-topics.sh "
- static final String KAFKA_SERVER_START = KAFKA_HOME + "/bin/kafka-server-start.sh "
- static final String KAFKA_SERVER_STOP = KAFKA_HOME + "/bin/kafka-server-stop.sh "
-
- @BeforeClass
- static void kafkaSetUp() {
Review comment:
The original code is trying to change the configuration value of `delete.topic.enable` by restating Kafka broker. Just running `/bin/kafka-server-stop.sh` does not work if the Kafka broker was started as a service via systemctl. `--smoke-tests` of docker provisioner is the case. Setting configurations required for smoke-tests in the config files should be simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] elukey commented on a change in pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
elukey commented on a change in pull request #832:
URL: https://github.com/apache/bigtop/pull/832#discussion_r774116519
##########
File path: bigtop-tests/smoke-tests/kafka/TestKafkaSmoke.groovy
##########
@@ -32,20 +32,7 @@ class TestKafkaSmoke {
static Shell sh = new Shell("/bin/bash -s");
static final String KAFKA_HOME = "/usr/lib/kafka"
- static final String KAFKA_CONFIG = KAFKA_HOME + "/config/server.properties "
static final String KAFKA_TOPICS = KAFKA_HOME + "/bin/kafka-topics.sh "
- static final String KAFKA_SERVER_START = KAFKA_HOME + "/bin/kafka-server-start.sh "
- static final String KAFKA_SERVER_STOP = KAFKA_HOME + "/bin/kafka-server-stop.sh "
-
- @BeforeClass
- static void kafkaSetUp() {
Review comment:
The idea in here is to run the smoke tests with kafka already up with the delete.topic.enable flag right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] elukey commented on a change in pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
elukey commented on a change in pull request #832:
URL: https://github.com/apache/bigtop/pull/832#discussion_r775215145
##########
File path: bigtop-tests/smoke-tests/kafka/TestKafkaSmoke.groovy
##########
@@ -32,20 +32,7 @@ class TestKafkaSmoke {
static Shell sh = new Shell("/bin/bash -s");
static final String KAFKA_HOME = "/usr/lib/kafka"
- static final String KAFKA_CONFIG = KAFKA_HOME + "/config/server.properties "
static final String KAFKA_TOPICS = KAFKA_HOME + "/bin/kafka-topics.sh "
- static final String KAFKA_SERVER_START = KAFKA_HOME + "/bin/kafka-server-start.sh "
- static final String KAFKA_SERVER_STOP = KAFKA_HOME + "/bin/kafka-server-stop.sh "
-
- @BeforeClass
- static void kafkaSetUp() {
Review comment:
I agree, makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on a change in pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
iwasakims commented on a change in pull request #832:
URL: https://github.com/apache/bigtop/pull/832#discussion_r775136310
##########
File path: bigtop-tests/smoke-tests/kafka/TestKafkaSmoke.groovy
##########
@@ -32,20 +32,7 @@ class TestKafkaSmoke {
static Shell sh = new Shell("/bin/bash -s");
static final String KAFKA_HOME = "/usr/lib/kafka"
- static final String KAFKA_CONFIG = KAFKA_HOME + "/config/server.properties "
static final String KAFKA_TOPICS = KAFKA_HOME + "/bin/kafka-topics.sh "
- static final String KAFKA_SERVER_START = KAFKA_HOME + "/bin/kafka-server-start.sh "
- static final String KAFKA_SERVER_STOP = KAFKA_HOME + "/bin/kafka-server-stop.sh "
-
- @BeforeClass
- static void kafkaSetUp() {
Review comment:
The original code is trying to change the configuration value of by restating Kafka broker. Just running `/bin/kafka-server-stop.sh` does not work if the Kafka broker was started as a service via systemctl. `--smoke-tests` of docker provisioner is the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
iwasakims commented on pull request #832:
URL: https://github.com/apache/bigtop/pull/832#issuecomment-1002306852
> Side note - Kafka 2.8.0 ships with KIP-500, that should allow running Kafka without Zookeeper (see https://issues.apache.org/jira/browse/KAFKA-9119). We could add a smoke test for this use case, to test with/without Zookeeper.
KIP-500 seems to be labeled as preview in branch-2.8. I think we can address this after bumping Kafka to 3.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims merged pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
iwasakims merged pull request #832:
URL: https://github.com/apache/bigtop/pull/832
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
iwasakims commented on pull request #832:
URL: https://github.com/apache/bigtop/pull/832#issuecomment-972683358
We need both zookeeper and kafka in the value of `--stack` for running smoke-tests by docker-provisioner like:
```
$ ./docker-hadoop.sh --create 1 --image bigtop/puppet:trunk-centos-8 --memory 16g --repo file:///bigtop-home/output --disable-gpg-check --stack zookeeper,kafka --smoke-tests kafka
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
iwasakims commented on pull request #832:
URL: https://github.com/apache/bigtop/pull/832#issuecomment-1010109320
I merged this. Thanks, @elukey.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] elukey commented on pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
elukey commented on pull request #832:
URL: https://github.com/apache/bigtop/pull/832#issuecomment-1010034584
I was of course lying, I was able to test your changes with the local repository settings.
Left a comment about some comments, but if those are ok feel free to proceed.
All good from my side! +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] elukey commented on pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
elukey commented on pull request #832:
URL: https://github.com/apache/bigtop/pull/832#issuecomment-1010009543
@iwasakims I can confirm that the fix works, I was able to build the package. I am currently unable to test the package via the Docker provisioner though, I opened https://issues.apache.org/jira/browse/BIGTOP-3630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
iwasakims commented on pull request #832:
URL: https://github.com/apache/bigtop/pull/832#issuecomment-1003010183
@elukey I can reproduce the 502 error on both CentOS 8 and Debian 11 now. I'm going to add the patch of KAFKA-12293 and additional fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
iwasakims commented on pull request #832:
URL: https://github.com/apache/bigtop/pull/832#issuecomment-972681305
The kafka-server package assumes services are controlled by systemd. The tests should not directly call scripts such as kafka-server-start.sh and kafka-server-stop.sh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] afsanjar commented on pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
afsanjar commented on pull request #832:
URL: https://github.com/apache/bigtop/pull/832#issuecomment-974125800
ignore my last comment - I see a bump for zookeeper as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on a change in pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
iwasakims commented on a change in pull request #832:
URL: https://github.com/apache/bigtop/pull/832#discussion_r775135570
##########
File path: bigtop-packages/src/common/kafka/do-component-build
##########
@@ -27,8 +27,6 @@ BUILD_OPTS="-Divy.home=${HOME}/.ivy2 -Dsbt.ivy.home=${HOME}/.ivy2 -Duser.home=${
# http://maven.40175.n5.nabble.com/Not-finding-artifact-in-local-repo-td3727753.html
export MAVEN_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=512m"
-gradle wrapper
Review comment:
It just fails due to unavailable resources. The cause might be version mismatch of gradle. (bigtop_toolchain installs 5.6.2.)
Since [generated wrapper script](https://github.com/apache/kafka/blob/2.8.1/gradlew) is provided, we don't need to generate it on our own.
```
$ gradle wrapper
Starting a Gradle Daemon, 1 busy Daemon could not be reused, use --status for details
FAILURE: Build failed with an exception.
* What went wrong:
A problem occurred configuring root project 'kafka'.
> Could not resolve all artifacts for configuration ':classpath'.
> Could not resolve org.eclipse.jgit:org.eclipse.jgit:latest.release.
Required by:
project : > org.ajoberstar.grgit:grgit-core:4.1.0
> Failed to list versions for org.eclipse.jgit:org.eclipse.jgit.
> Unable to load Maven meta-data from https://dl.bintray.com/content/netflixoss/external-gradle-plugins/org/eclipse/jgit/org.eclipse.jgit/maven-metadata.xml.
> Could not get resource 'https://dl.bintray.com/content/netflixoss/external-gradle-plugins/org/eclipse/jgit/org.eclipse.jgit/maven-metadata.xml'.
> Could not GET 'https://dl.bintray.com/content/netflixoss/external-gradle-plugins/org/eclipse/jgit/org.eclipse.jgit/maven-metadata.xml'. Received status code 502 from server: Bad Gateway
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 18s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] elukey commented on pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
elukey commented on pull request #832:
URL: https://github.com/apache/bigtop/pull/832#issuecomment-1001138982
@iwasakims I found [this](https://github.com/apache/kafka/pull/10056) kafka issue that seem to remove the dl.bintray.com problem. I adapted the patch for the 2.8 branch:
```
diff --git a/build.gradle b/build.gradle
index e21609fd49..a187004b69 100644
--- a/build.gradle
+++ b/build.gradle
@@ -20,12 +20,10 @@ import java.nio.charset.StandardCharsets
buildscript {
repositories {
mavenCentral()
- jcenter()
maven {
url "https://plugins.gradle.org/m2/"
}
}
- apply from: file('gradle/buildscript.gradle'), to: buildscript
apply from: "$rootDir/gradle/dependencies.gradle"
dependencies {
diff --git a/gradle/buildscript.gradle b/gradle/buildscript.gradle
deleted file mode 100644
index 83967bb47d..0000000000
--- a/gradle/buildscript.gradle
+++ /dev/null
@@ -1,23 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one or more
-// contributor license agreements. See the NOTICE file distributed with
-// this work for additional information regarding copyright ownership.
-// The ASF licenses this file to You under the Apache License, Version 2.0
-// (the "License"); you may not use this file except in compliance with
-// the License. You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-repositories {
- repositories {
- // For license plugin.
- maven {
- url 'https://dl.bintray.com/content/netflixoss/external-gradle-plugins/'
- }
- }
-}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] elukey commented on a change in pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.
Posted by GitBox <gi...@apache.org>.
elukey commented on a change in pull request #832:
URL: https://github.com/apache/bigtop/pull/832#discussion_r775215110
##########
File path: bigtop-packages/src/common/kafka/do-component-build
##########
@@ -27,8 +27,6 @@ BUILD_OPTS="-Divy.home=${HOME}/.ivy2 -Dsbt.ivy.home=${HOME}/.ivy2 -Duser.home=${
# http://maven.40175.n5.nabble.com/Not-finding-artifact-in-local-repo-td3727753.html
export MAVEN_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=512m"
-gradle wrapper
Review comment:
Ack thanks for the explanation :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org