You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Andy Salnikov <a_...@yahoo.com> on 2009/06/26 23:48:12 UTC
svn -v list shows '.' in new version
Hi,
I posted this to users list some time ago but could not get any input on this, is this a bug or not?
We have upgraded from SVN 1.4 to 1.6 and I noticed one small inconsistency in the output produced by 'svn -v list' command. In new version the ouput also shows '.' directory which did not happen in the old version. Here is an example:
svn 1.4:
bbt-odf100 [429] /usr/bin/svn -v list "$LUSI_SVN/SciMD/tags"
297 gapon May 03 18:19 V00-00-01/
306 gapon May 05 08:42 V00-00-02/
308 gapon May 05 18:58 V00-00-03/
310 gapon May 05 19:05 V00-00-04/
329 gapon May 19 01:00 V00-00-05/
339 gapon May 19 12:37 V00-00-06/
svn 1.6:
bbt-odf100 [430] /usr/local/bin/svn -v list "$LUSI_SVN/SciMD/tags"
339 gapon May 19 12:37 ./
297 gapon May 03 18:19 V00-00-01/
306 gapon May 05 08:42 V00-00-02/
308 gapon May 05 18:58 V00-00-03/
310 gapon May 05 19:05 V00-00-04/
329 gapon May 19 01:00 V00-00-05/
339 gapon May 19 12:37 V00-00-06/
Without -v option both version produce identical output without '.' directory.
Before I submit a bug report for this I just wanted to ask if this change in behavior was intentional or not?
Thanks,
Andy.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2365871
Re: svn -v list shows '.' in new version
Posted by Julian Foad <ju...@btopenworld.com>.
I (Julian Foad) wrote:
> Andy Salnikov wrote:
> > > Andy Salnikov wrote:
> > > > > Andy Salnikov wrote:
> > > > > > We have upgraded from SVN 1.4 to 1.6 and I noticed one small
> > > > > > inconsistency in the output produced by 'svn -v list' command.
> [...]
> > > > > Thanks for the report. I think this is an unintentional change - in
> > > > > other words, a regression.
>
> Looking at the code now, it looks like the behaviour is intentional.
> There's specific code to produce that result, with a comment:
[...]
I looked at the history. It was changed between versions 1.4 and 1.5,
while adding support for the "--depth" option:
------------------------------------------------------------------------
r24510 | kfogel | 2007-04-10 08:23:51 +0100 (Tue, 10 Apr 2007) | 19
lines
Upgrade svn_client_list() with recurse to svn_client_list2() with depth.
* subversion/include/svn_client.h
(svn_client_list2): New declaration.
(svn_client_list): Deprecate.
(svn_client_list_func_t): Tweak documentation.
* subversion/libsvn_client/list.c
(svn_client_list2): Define, using body of old svn_client_list.
(svn_client_list): Implement as wrapper around svn_client_list2.
(get_dir_contents): Take depth instead of recurse, adjust accordingly.
* subversion/svn/list-cmd.c
(print_dirent, print_dirent_xml): When verbose, print this-dir
entry instead of ignoring it.
(svn_cl__list): Call svn_client_list2 now.
* notes/sparse-directories.txt: Remove this item from the todo list.
------------------------------------------------------------------------
So it was a (perhaps undocumented) behaviour change, and I cannot now
call it a bug.
- Julian
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2368381
RE: Re: svn -v list shows '.' in new version
Posted by Julian Foad <ju...@btopenworld.com>.
Andy Salnikov wrote:
> > Andy Salnikov wrote:
> > > > Andy Salnikov wrote:
> > > > > We have upgraded from SVN 1.4 to 1.6 and I noticed one small
> > > > > inconsistency in the output produced by 'svn -v list' command.
[...]
> > > > Thanks for the report. I think this is an unintentional change - in
> > > > other words, a regression.
Looking at the code now, it looks like the behaviour is intentional.
There's specific code to produce that result, with a comment:
subversion/svn/list-cmd.c: print_dirent():
if (strcmp(path, "") == 0)
{
if (dirent->kind == svn_node_file)
entryname = svn_dirent_basename(abs_path, pool);
else if (pb->verbose)
entryname = ".";
else
/* Don't bother to list if no useful information will be shown.
*/
return SVN_NO_ERROR;
}
else
entryname = path;
> I tried to submit a bug, but the Issue Tracker does not let me do it.
> Here is the message I get from it:
>
> """
> Enter issue
> Permission denied
>
> Enter issue
> The user '0' does not have the permissions necessary to perform this
> action or the session has timed out.
>
> Please Login and try again.
> """
>
> Not sure what the problem is, I made sure that I'm logged in.
Sorry, I don't know what's up with the issue tracker.
> As for fixing it myself - unfortunately I can not spend much more time
> on it than simply reporting what I see.
That's OK. Thanks for reporting.
I wrote a regression test, which is attached as a patch. But I'll check
that we agree this is a bug before I commit it. Sorry, no time to look
further right now.
- Julian
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2367839
RE: Re: svn -v list shows '.' in new version
Posted by Andy Salnikov <a_...@yahoo.com>.
> Andy Salnikov wrote:
> > > Andy Salnikov wrote:
> > > > We have upgraded from SVN 1.4 to 1.6 and I noticed one small
> > > > inconsistency in the output produced by 'svn -v list' command.
> > > > ...
> > >
> > > Andy,
> > >
> > > Thanks for the report. I think this is an unintentional change - in
> > > other words, a regression.
> > >
> > > - Julian
> >
> > Hi Julian,
> >
> > thank you for reply. I presume it's going to be fixed then, or should
> > I submit a bug report too?
>
> Hi Andy.
>
> I should have said more in my reply. No, one can't assume that a bug
> that's reported will be fixed. Yes, everyone (users and developers)
> would like all the bugs to be fixed but there are only a very few people
> actually working on Subversion at any one time, and of course they're
> already working on whatever they're working on.
>
> Please do file an issue in the issue tracker. At least, that way, it
> won't be forgotten.
>
> If you are willing and able to get involved in fixing this, the first
> thing that would really really boost the likelihood and speed of a fix
> is if you can add a regression test for this behaviour.
>
Hi Julian,
I tried to submit a bug, but the Issue Tracker does not let me do it. Here is the message I get from it:
"""
Enter issue
Permission denied
Enter issue
The user '0' does not have the permissions necessary to perform this action or the session has timed out.
Please Login and try again.
"""
Not sure what the problem is, I made sure that I'm logged in.
As for fixing it myself - unfortunately I can not spend much more time on it than simply reporting what I see.
Thanks,
Andy.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2367247
RE: Re: svn -v list shows '.' in new version
Posted by Julian Foad <ju...@btopenworld.com>.
Andy Salnikov wrote:
> > Andy Salnikov wrote:
> > > We have upgraded from SVN 1.4 to 1.6 and I noticed one small
> > > inconsistency in the output produced by 'svn -v list' command.
> > > ...
> >
> > Andy,
> >
> > Thanks for the report. I think this is an unintentional change - in
> > other words, a regression.
> >
> > - Julian
>
> Hi Julian,
>
> thank you for reply. I presume it's going to be fixed then, or should
> I submit a bug report too?
Hi Andy.
I should have said more in my reply. No, one can't assume that a bug
that's reported will be fixed. Yes, everyone (users and developers)
would like all the bugs to be fixed but there are only a very few people
actually working on Subversion at any one time, and of course they're
already working on whatever they're working on.
Please do file an issue in the issue tracker. At least, that way, it
won't be forgotten.
If you are willing and able to get involved in fixing this, the first
thing that would really really boost the likelihood and speed of a fix
is if you can add a regression test for this behaviour.
I'm looking... The tests for "svn list" are in
subversion/tests/cmdline/basic_tests.py:
basic_ls()
ls_nonhead()
ls_space_in_repo_name()
None of them lists a directory in verbose mode.
A good approach would be to add the new test as a regression test
specifically for this issue, so it need only test one instance of
listing a directory and not try to check any other aspect of the
behaviour.
If you copy and paste one of the existing test functions to the end of
the file, with a new name, and add its name to the list at the end of
the file, that's all. To run test number 19:
(cd obj-dir/subversion/tests/cmdline/ && ./basic_tests.py 19)
or to find the number of your new test:
(cd obj-dir/subversion/tests/cmdline/ && ./basic_tests.py list)
If you can't get involved, that's fine too, of course.
- Julian
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2366979
RE: Re: svn -v list shows '.' in new version
Posted by Andy Salnikov <a_...@yahoo.com>.
> Andy Salnikov wrote:
> > We have upgraded from SVN 1.4 to 1.6 and I noticed one small
> > inconsistency in the output produced by 'svn -v list' command.
> > ...
>
> Andy,
>
> Thanks for the report. I think this is an unintentional change - in
> other words, a regression.
>
> - Julian
Hi Julian,
thank you for reply. I presume it's going to be fixed then, or should I submit a bug report too?
Thanks,
Andy.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2366935
Re: svn -v list shows '.' in new version
Posted by Julian Foad <ju...@btopenworld.com>.
Andy Salnikov wrote:
> We have upgraded from SVN 1.4 to 1.6 and I noticed one small
> inconsistency in the output produced by 'svn -v list' command. In new
> version the ouput also shows '.' directory which did not happen in the
> old version. Here is an example:
>
> svn 1.4:
> bbt-odf100 [429] /usr/bin/svn -v list "$LUSI_SVN/SciMD/tags"
> 297 gapon May 03 18:19 V00-00-01/
[...]
> svn 1.6:
> bbt-odf100 [430] /usr/local/bin/svn -v list "$LUSI_SVN/SciMD/tags"
> 339 gapon May 19 12:37 ./
> 297 gapon May 03 18:19 V00-00-01/
[...]
> Without -v option both version produce identical output without '.'
> directory.
>
> Before I submit a bug report for this I just wanted to ask if this
> change in behavior was intentional or not?
Andy,
Thanks for the report. I think this is an unintentional change - in
other words, a regression.
- Julian
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2366352