You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by Silven1117 <gi...@git.apache.org> on 2018/04/18 16:34:12 UTC

[GitHub] flink pull request #5875: [FLINK-9210] Removed unnecessary getValue calls in...

GitHub user Silven1117 opened a pull request:

    https://github.com/apache/flink/pull/5875

    [FLINK-9210] Removed unnecessary getValue calls in serializeGauge

    ## What is the purpose of the change
    
    * This pull request removes unnecessary gauge.getValue() call in MetricDumpSerialization.serializeGauge(). That way gauge value can reset inside getValue upon serialization. This allows gauge value to be reset at the time metric reporter prepares gauge value for the report.
    
    
    ## Brief change log
    
      - gauge.getValue() gets called only once in MetricDumpSerialization.serializeGauge()
    
    
    ## Verifying this change
    
    This change is already covered by existing tests, such as MetricDumpSerializerTest.
    
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`:  no
      - The serializers: no(changes live in the MetricDumpSerialization but it would not affect)
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not applicable


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Silven1117/flink metric

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5875.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5875
    
----
commit 0eb7d7dcd089f0f6a909b1577d662bb1942db192
Author: Jisu You <j0...@...>
Date:   2018-04-18T16:23:28Z

    [FLINK-9210] Removed unnecessary getValue call in serializeGauge

----


---

[GitHub] flink issue #5875: [FLINK-9210] Removed unnecessary getValue calls in serial...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5875
  
    The issue has already been resolved.


---

[GitHub] flink pull request #5875: [FLINK-9210] Removed unnecessary getValue calls in...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5875


---

[GitHub] flink issue #5875: [FLINK-9210] Removed unnecessary getValue calls in serial...

Posted by Silven1117 <gi...@git.apache.org>.

Github user Silven1117 commented on the issue:

    https://github.com/apache/flink/pull/5875
  
    This could've been my very first open source contribution :(


---

[GitHub] flink issue #5875: [FLINK-9210] Removed unnecessary getValue calls in serial...

Posted by Silven1117 <gi...@git.apache.org>.

Github user Silven1117 commented on the issue:

    https://github.com/apache/flink/pull/5875
  
    Thanks that would be great! Will assign myself next time I create issues.


---

[GitHub] flink issue #5875: [FLINK-9210] Removed unnecessary getValue calls in serial...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5875
  
    @Silven1117 My apologies, i went right at it since it was such an quick fix. I recommend writing in the JIRA that you would like to work on the issue yourself. I will give you contributor permissions so you can even assign issues to yourself.


---