[GitHub] [rocketmq] duhenglucky commented on a change in pull request #1417: [ISSUE #1416] Delete ConsumerGroupName && Clean offsetTable

[GitBox <gi...@apache.org>]

duhenglucky commented on a change in pull request #1417: [ISSUE #1416]  Delete ConsumerGroupName && Clean offsetTable
URL: https://github.com/apache/rocketmq/pull/1417#discussion_r324515185
 
 

 ##########
 File path: broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
 ##########
 @@ -682,11 +682,24 @@ private RemotingCommand deleteSubscriptionGroup(ChannelHandlerContext ctx,
         log.info("deleteSubscriptionGroup called by {}", RemotingHelper.parseChannelRemoteAddr(ctx.channel()));
 
         this.brokerController.getSubscriptionGroupManager().deleteSubscriptionGroupConfig(requestHeader.getGroupName());
-
+        // only cleanConsumerOffsetList maker 
+        this.brokerController.getConsumerOffsetManager().cleanConsumerOffsetList(requestHeader.getGroupName());
         response.setCode(ResponseCode.SUCCESS);
         response.setRemark(null);
         return response;
     }
+    
+ //  private RemotingCommand cleanConsumerOffsetList(ChannelHandlerContext ctx,
 
 Review comment:
   @Liberxue could you remove these useless codes?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services