You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Stanton Sievers (Created) (JIRA)" <ji...@apache.org> on 2011/10/31 13:25:32 UTC

[jira] [Created] (SHINDIG-1654) Remove unused configuration in shindig.properties for proxy and concat urls

Remove unused configuration in shindig.properties for proxy and concat urls
---------------------------------------------------------------------------

                 Key: SHINDIG-1654
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1654
             Project: Shindig
          Issue Type: Bug
          Components: Java
    Affects Versions: 3.0.0
            Reporter: Stanton Sievers
            Priority: Trivial
             Fix For: 3.0.0


The following lines in shindig.properties have been deprecated in favor of defining them in container.js.  It seems they were implemented in container.js but the old configuration was never removed.

shindig.content-rewrite.proxy-url=%contextRoot%/gadgets/proxy?container=default&url=
shindig.content-rewrite.concat-url=%contextRoot%/gadgets/concat?container=default&


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SHINDIG-1654) Remove unused configuration in shindig.properties for proxy and concat urls

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141818#comment-13141818 ] 

jiraposter@reviews.apache.org commented on SHINDIG-1654:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2640/#review3005
-----------------------------------------------------------


Stanton I am having a problem applying the patch, could you update and regenerate the patch?

- Ryan


On 2011-10-31 12:28:02, Stanton Sievers wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2640/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-31 12:28:02)
bq.  
bq.  
bq.  Review request for shindig.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  The following lines in shindig.properties have been deprecated in favor of defining them in container.js. It seems they were implemented in container.js but the old configuration was never removed.
bq.  
bq.  shindig.content-rewrite.proxy-url=%contextRoot%/gadgets/proxy?container=default&url=
bq.  shindig.content-rewrite.concat-url=%contextRoot%/gadgets/concat?container=default& 
bq.  
bq.  
bq.  This addresses bug SHINDIG-1654.
bq.      https://issues.apache.org/jira/browse/SHINDIG-1654
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1190346 
bq.  
bq.  Diff: https://reviews.apache.org/r/2640/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Build/Junit passed
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Stanton
bq.  
bq.


                
> Remove unused configuration in shindig.properties for proxy and concat urls
> ---------------------------------------------------------------------------
>
>                 Key: SHINDIG-1654
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1654
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 3.0.0
>            Reporter: Stanton Sievers
>            Priority: Trivial
>             Fix For: 3.0.0
>
>         Attachments: ConcatProxyPropertiesPatch.txt
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> The following lines in shindig.properties have been deprecated in favor of defining them in container.js.  It seems they were implemented in container.js but the old configuration was never removed.
> shindig.content-rewrite.proxy-url=%contextRoot%/gadgets/proxy?container=default&url=
> shindig.content-rewrite.concat-url=%contextRoot%/gadgets/concat?container=default&

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SHINDIG-1654) Remove unused configuration in shindig.properties for proxy and concat urls

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140220#comment-13140220 ] 

jiraposter@reviews.apache.org commented on SHINDIG-1654:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2640/#review2947
-----------------------------------------------------------

Ship it!


LGTM

- Jesse


On 2011-10-31 12:28:02, Stanton Sievers wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2640/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-31 12:28:02)
bq.  
bq.  
bq.  Review request for shindig.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  The following lines in shindig.properties have been deprecated in favor of defining them in container.js. It seems they were implemented in container.js but the old configuration was never removed.
bq.  
bq.  shindig.content-rewrite.proxy-url=%contextRoot%/gadgets/proxy?container=default&url=
bq.  shindig.content-rewrite.concat-url=%contextRoot%/gadgets/concat?container=default& 
bq.  
bq.  
bq.  This addresses bug SHINDIG-1654.
bq.      https://issues.apache.org/jira/browse/SHINDIG-1654
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1190346 
bq.  
bq.  Diff: https://reviews.apache.org/r/2640/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Build/Junit passed
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Stanton
bq.  
bq.


                
> Remove unused configuration in shindig.properties for proxy and concat urls
> ---------------------------------------------------------------------------
>
>                 Key: SHINDIG-1654
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1654
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 3.0.0
>            Reporter: Stanton Sievers
>            Priority: Trivial
>             Fix For: 3.0.0
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> The following lines in shindig.properties have been deprecated in favor of defining them in container.js.  It seems they were implemented in container.js but the old configuration was never removed.
> shindig.content-rewrite.proxy-url=%contextRoot%/gadgets/proxy?container=default&url=
> shindig.content-rewrite.concat-url=%contextRoot%/gadgets/concat?container=default&

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (SHINDIG-1654) Remove unused configuration in shindig.properties for proxy and concat urls

Posted by "Paul Lindner (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Lindner closed SHINDIG-1654.
---------------------------------


part of 2.5.0-beta1 release.

                
> Remove unused configuration in shindig.properties for proxy and concat urls
> ---------------------------------------------------------------------------
>
>                 Key: SHINDIG-1654
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1654
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 2.5.0-beta1
>            Reporter: Stanton Sievers
>            Priority: Trivial
>             Fix For: 2.5.0-beta1
>
>         Attachments: ConcatProxyPropertiesPatch.txt
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> The following lines in shindig.properties have been deprecated in favor of defining them in container.js.  It seems they were implemented in container.js but the old configuration was never removed.
> shindig.content-rewrite.proxy-url=%contextRoot%/gadgets/proxy?container=default&url=
> shindig.content-rewrite.concat-url=%contextRoot%/gadgets/concat?container=default&

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SHINDIG-1654) Remove unused configuration in shindig.properties for proxy and concat urls

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140089#comment-13140089 ] 

jiraposter@reviews.apache.org commented on SHINDIG-1654:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2640/
-----------------------------------------------------------

Review request for shindig.


Summary
-------

The following lines in shindig.properties have been deprecated in favor of defining them in container.js. It seems they were implemented in container.js but the old configuration was never removed.

shindig.content-rewrite.proxy-url=%contextRoot%/gadgets/proxy?container=default&url=
shindig.content-rewrite.concat-url=%contextRoot%/gadgets/concat?container=default& 


This addresses bug SHINDIG-1654.
    https://issues.apache.org/jira/browse/SHINDIG-1654


Diffs
-----

  http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1190346 

Diff: https://reviews.apache.org/r/2640/diff


Testing
-------

Build/Junit passed


Thanks,

Stanton


                
> Remove unused configuration in shindig.properties for proxy and concat urls
> ---------------------------------------------------------------------------
>
>                 Key: SHINDIG-1654
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1654
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 3.0.0
>            Reporter: Stanton Sievers
>            Priority: Trivial
>             Fix For: 3.0.0
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> The following lines in shindig.properties have been deprecated in favor of defining them in container.js.  It seems they were implemented in container.js but the old configuration was never removed.
> shindig.content-rewrite.proxy-url=%contextRoot%/gadgets/proxy?container=default&url=
> shindig.content-rewrite.concat-url=%contextRoot%/gadgets/concat?container=default&

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SHINDIG-1654) Remove unused configuration in shindig.properties for proxy and concat urls

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141824#comment-13141824 ] 

jiraposter@reviews.apache.org commented on SHINDIG-1654:
--------------------------------------------------------



bq.  On 2011-11-02 00:57:54, Ryan Baxter wrote:
bq.  > Stanton I am having a problem applying the patch, could you update and regenerate the patch?

NM looks like Henry committed this :)


- Ryan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2640/#review3005
-----------------------------------------------------------


On 2011-10-31 12:28:02, Stanton Sievers wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2640/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-31 12:28:02)
bq.  
bq.  
bq.  Review request for shindig.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  The following lines in shindig.properties have been deprecated in favor of defining them in container.js. It seems they were implemented in container.js but the old configuration was never removed.
bq.  
bq.  shindig.content-rewrite.proxy-url=%contextRoot%/gadgets/proxy?container=default&url=
bq.  shindig.content-rewrite.concat-url=%contextRoot%/gadgets/concat?container=default& 
bq.  
bq.  
bq.  This addresses bug SHINDIG-1654.
bq.      https://issues.apache.org/jira/browse/SHINDIG-1654
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1190346 
bq.  
bq.  Diff: https://reviews.apache.org/r/2640/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Build/Junit passed
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Stanton
bq.  
bq.


                
> Remove unused configuration in shindig.properties for proxy and concat urls
> ---------------------------------------------------------------------------
>
>                 Key: SHINDIG-1654
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1654
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 3.0.0
>            Reporter: Stanton Sievers
>            Priority: Trivial
>             Fix For: 3.0.0
>
>         Attachments: ConcatProxyPropertiesPatch.txt
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> The following lines in shindig.properties have been deprecated in favor of defining them in container.js.  It seems they were implemented in container.js but the old configuration was never removed.
> shindig.content-rewrite.proxy-url=%contextRoot%/gadgets/proxy?container=default&url=
> shindig.content-rewrite.concat-url=%contextRoot%/gadgets/concat?container=default&

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (SHINDIG-1654) Remove unused configuration in shindig.properties for proxy and concat urls

Posted by "Stanton Sievers (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stanton Sievers updated SHINDIG-1654:
-------------------------------------

    Attachment: ConcatProxyPropertiesPatch.txt
    
> Remove unused configuration in shindig.properties for proxy and concat urls
> ---------------------------------------------------------------------------
>
>                 Key: SHINDIG-1654
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1654
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 3.0.0
>            Reporter: Stanton Sievers
>            Priority: Trivial
>             Fix For: 3.0.0
>
>         Attachments: ConcatProxyPropertiesPatch.txt
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> The following lines in shindig.properties have been deprecated in favor of defining them in container.js.  It seems they were implemented in container.js but the old configuration was never removed.
> shindig.content-rewrite.proxy-url=%contextRoot%/gadgets/proxy?container=default&url=
> shindig.content-rewrite.concat-url=%contextRoot%/gadgets/concat?container=default&

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (SHINDIG-1654) Remove unused configuration in shindig.properties for proxy and concat urls

Posted by "Henry Saputra (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henry Saputra resolved SHINDIG-1654.
------------------------------------

    Resolution: Fixed

Patch applied: rev 1196334
                
> Remove unused configuration in shindig.properties for proxy and concat urls
> ---------------------------------------------------------------------------
>
>                 Key: SHINDIG-1654
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1654
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 3.0.0
>            Reporter: Stanton Sievers
>            Priority: Trivial
>             Fix For: 3.0.0
>
>         Attachments: ConcatProxyPropertiesPatch.txt
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> The following lines in shindig.properties have been deprecated in favor of defining them in container.js.  It seems they were implemented in container.js but the old configuration was never removed.
> shindig.content-rewrite.proxy-url=%contextRoot%/gadgets/proxy?container=default&url=
> shindig.content-rewrite.concat-url=%contextRoot%/gadgets/concat?container=default&

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira