[jira] [Commented] (GEODE-3179) The verifyBundledJarsHaveNotChanged test is failing due to slf4j-jdk

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084254#comment-16084254 ] 

ASF GitHub Bot commented on GEODE-3179:
---------------------------------------

GitHub user DivineEnder opened a pull request:

    https://github.com/apache/geode/pull/626

    GEODE-3179: Fixing bundled jars test finding slf4j-jdk jar

    This fixes the failing verify bundled jars test, caused by an unexpected slf4j-jdk jar coming from the tomcat module folder when extracted.
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    - [ ] Does `gradlew build` run cleanly?
    
    - [ ] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DivineEnder/geode feature/GEODE-3179

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/626.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #626
    
----
commit b662c9b08537ebffadf3427f616f6aad5f2a8daf
Author: David Anuta <da...@gmail.com>
Date:   2017-07-10T23:40:07Z

    GEODE-3179: Changed extract directory of the Tomcat module
    
    This fixes the failing verify bundled jars test, caused by an unexpected slf4j-jdk jar coming from the tomcat module folder when extracted.

----


> The verifyBundledJarsHaveNotChanged test is failing due to slf4j-jdk
> --------------------------------------------------------------------
>
>                 Key: GEODE-3179
>                 URL: https://issues.apache.org/jira/browse/GEODE-3179
>             Project: Geode
>          Issue Type: Bug
>          Components: http session, tests
>            Reporter: David Anuta
>            Assignee: David Anuta
>
> Test is failing with:
> Error
> java.lang.AssertionError: The bundled jars have changed. Please make sure
> you update the licence and notice
> as described in
> https://cwiki.apache.org/confluence/display/GEODE/License+Guide+for+Contributors
> When fixed, copy geode-assembly/build/test/bundled_jars.txt
> to src/test/resources/expected_jars.txt
> Removed Jars
> --------------
> Added Jars
> --------------
> slf4j-jdk
> Stacktrace
> java.lang.AssertionError: The bundled jars have changed. Please make sure
> you update the licence and notice
> as described in
> https://cwiki.apache.org/confluence/display/GEODE/License+Guide+for+Contributors
> When fixed, copy geode-assembly/build/test/bundled_jars.txt
> to src/test/resources/expected_jars.txt
> Removed Jars
> --------------
> Added Jars
> --------------
> slf4j-jdk
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at
> org.apache.geode.BundledJarsJUnitTest.verifyBundledJarsHaveNotChanged(BundledJarsJUnitTest.java:81)
> Likely due to Cargo session testing added in GEODE-2901.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)